Skip to content

Ignored .less styles with min-width: (@screen__l) #39817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 of 5 tasks
LeonidTomashevskyAmasty opened this issue Apr 15, 2025 · 8 comments
Open
3 of 5 tasks

Ignored .less styles with min-width: (@screen__l) #39817

LeonidTomashevskyAmasty opened this issue Apr 15, 2025 · 8 comments
Labels
Area: Catalog Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Reported on 2.4.8 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@LeonidTomashevskyAmasty
Copy link

LeonidTomashevskyAmasty commented Apr 15, 2025

Preconditions and environment

  • Magento version 2.4.8
  • sample data. Or a category with at least 5 visible products
  • Screen size more then 1024px
  • default Luma theme

Steps to reproduce

  1. Open Category Page with products
  2. count columns in the first product row

Expected result

products in 4 columns
Image

Actual result

products in 3 columns
Image

Additional information

the commit 438f978 breaks all styles within .media-width(@extremum, @break) when (@extremum = 'min') and (@break = @screen__l) { like in

.media-width(@extremum, @break) when (@extremum = 'min') and (@break = @screen__l) {
.products-grid {
.product-item {
width: (100%/5);
}
}
.page-layout-1column {
.products-grid {
.product-item {
width: (100%/6);
}
}
}
.page-layout-3columns {
.products-grid {
.product-item {
width: (100%/4);
}
}
}

All this styles https://github.com/search?q=repo%3Amagento%2Fmagento2+%22.media-width%28%40extremum%2C+%40break%29+when+%28%40extremum+%3D+%27min%27%29+and+%28%40break+%3D+%40screen__l%29+%7B%22&type=code are ignored on 2.4.8

Release note

Fix lost responsive styles for desktop

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Apr 15, 2025

Hi @LeonidTomashevskyAmasty. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented Apr 15, 2025

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.8 Indicates original Magento version for the Issue report. label Apr 15, 2025
@engcom-Bravo
Copy link
Contributor

Hi @LeonidTomashevskyAmasty,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and 2.4.8,2.4.8-beta2 and we are not able to reproduce the issue.kindly refer the attached video.

Screen.Recording.2025-04-16.at.3.25.55.pm.mov

Could you please let us know still if we are missing anything.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Apr 16, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Apr 16, 2025
@LeonidTomashevskyAmasty
Copy link
Author

Hi @engcom-Bravo
Seems like you got confused with Actual result and Expected.
Expected 4 columns, not 3 like in you video.
3 columns should be visible only for window less than 768px.
You can compare with 2.4.7, there is 4 columns as expected

@engcom-Bravo
Copy link
Contributor

Hi @LeonidTomashevskyAmasty,

Thanks for your update.

We have tried to reproduce the issue in latest 2.4-develop instance and 2.4.8 and we are able to reproduce the issue.Kindly refer the screenshots.

2.4.7-p3

Image

2.4-develop

Image

2.4.8

Image

products in 3 columns.Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Area: Catalog and removed Issue: needs update Additional information is require, waiting for response labels Apr 17, 2025
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-14463 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Apr 17, 2025

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@alexey-motorny-amasty
Copy link

The Amasty team has prepared a fix for this issue as well as some others. To apply the fix, you need to run the following command: composer require amasty/module-mage-248-fix -W. For more details, see here: https://github.com/AmastyLtd/module-mage-248-fix .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Catalog Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Reported on 2.4.8 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Status: Ready for Development
Development

No branches or pull requests

4 participants