Skip to content

Use of --lock-env on bin/magento config:set twofactorauth/general/force_providers results in bin/magento errors #39836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 tasks
MylesForrest opened this issue Apr 17, 2025 · 5 comments
Labels
Area: Security Component: Security Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Reported on 2.4.8 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@MylesForrest
Copy link

MylesForrest commented Apr 17, 2025

Preconditions and environment

Encountered during install and configuration of 2.4.8 (Community)

Steps to reproduce

Run bin/magento config:set --lock-env twofactorauth/general/force_providers google.

Observe that env.php now contains:

'twofactorauth' => [
    'general' => [
        'force_providers' => [
            'google'
        ]
    ]
]

Run bin/magento.
Run bin/magento with a command specified.

Expected result

bin/magento lists commands without error.
bin/magento with a command specified does not produce an error.

Actual result

bin/magento output ends with:

Type Error occurred when creating object: Magento\TwoFactorAuth\Model\Provider\Engine\DuoSecurity, explode(): Argument #2 ($string) must be of type string, array given 

bin/magento with a command specified yields:

There are no commands defined in the "config" namespace.  
                                                            
  Did you mean one of these?                                
      module:config                                         
      setup:config                                          
      setup:store-config 

Additional information

Dug in a bit - vendor/magento/module-two-factor-auth/Model/Provider/Engine/DuoSecurity.php L:199 is returned the array from env.php if --lock-env was used during the config:set.

isDuoForcedProvider expects a string, not an array.

Can be worked around by manually setting env.php:

'twofactorauth' => [
    'general' => [
        'force_providers' => 'google'
    ]
]

Haven't dug in enough yet to determine if the underlying issue is with vendor/magento/module-config/Console/Command/ConfigSet/LockProcessor.php or vendor/magento/module-two-factor-auth/Model/Config/Backend/ForceProviders.php.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Apr 17, 2025

Hi @MylesForrest. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented Apr 21, 2025

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel engcom-Hotel added the Reported on 2.4.8 Indicates original Magento version for the Issue report. label Apr 21, 2025
@engcom-November
Copy link
Contributor

Hello @MylesForrest

Thank you for your report and collaboration,

We attempted to reproduce the issue in the latest 2.4-develop and 2.4.8 instances. We are able to reproduce the issue. Please refer to the attached screenshot.

Image Image

Steps to reproduce

  • Run bin/magento config:set --lock-env twofactorauth/general/force_providers google.
  • Run bin/magento.

We followed the preconditions and steps as provided and encountered the issue. Therefore, we are marking this ticket as "Issue: Confirmed."

Thank You!

@engcom-November engcom-November added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Security Component: Security Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 21, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Apr 21, 2025
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-14471 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Apr 21, 2025

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Security Component: Security Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Reported on 2.4.8 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Status: Ready for Development
Development

No branches or pull requests

4 participants