Refactor quote address do validate method

[SerhiiMandrykin]

Description (*)

While debugging address validation I noticed that \Magento\Quote\Model\QuoteAddressValidator::doValidate needs to be refactored and optimized.

My PR includes readability improvements to thedoValidate method

Related Pull Requests

Manual testing scenarios (*)

1. Add a product to the shopping cart
2. Go to the shopping cart

Questions or comments

I think that the exceptions thrown are not relevant in this case and the messages like Invalid customer address id %1 are not clear. I think we need to change it as well.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] refactor quote address do validate method #38230: refactor quote address do validate method

[m2-assistant]

Hi @SerhiiMandrykin. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[ihor-sviziev]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[ihor-sviziev]

✔ Approved.

Failing tests look not related to changes from this PR.

[engcom-Hotel]

@magento create issue

[engcom-November]

Since this is a code refactor, manual testing is not applicable.

Refactored code looks good, hence moving this to Extended Testing.

[engcom-November]

@magento run all tests

[engcom-November]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Unit Tests

[engcom-November]

All the builds are green, hence moving it to Merge in progress

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Functional Tests B2B

[engcom-Dash]

Test failures for Functional B2B are inconsistent and seems to be flaky. They neither part of PR nor failing because of the PR changes.

Build 1: Allure Report - B2B

Build 2: Allure Report - B2B

Hence moving this PR in Merge In Progress