Skip to content

Removed email disclosure #39570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: 2.4-develop
Choose a base branch
from
Open

Removed email disclosure #39570

wants to merge 12 commits into from

Conversation

Mohamed-Asar
Copy link
Contributor

@Mohamed-Asar Mohamed-Asar commented Jan 27, 2025 •
edited by m2-assistant bot
Loading

Description (*)

Display an error message indicating an incorrect email if the entered email is not required to confirm the account, regardless of whether the customer exists or not.

customer/account/confirmation

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Removed email disclosure #39574: Removed email disclosure

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Jan 27, 2025

Hi @Mohamed-Asar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Jan 27, 2025
@Mohamed-Asar
Copy link
Contributor Author

@magento run all tests.

@magento-automated-testing Magento Automated Testing
Copy link

Failed to run the builds. Please try to re-run them later.

@Mohamed-Asar
Copy link
Contributor Author

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jan 28, 2025
Open
5 tasks
@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 28, 2025
@Mohamed-Asar
Copy link
Contributor Author

@magento run all tests

@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Feb 12, 2025
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

Hello @Mohamed-Asar,

Thank you for the contribution!

As the related issue has been marked as a feature request, we require PO approval for this PR.

Therefore, we are marking this PR as On Hold and have sent an email to the PO for their approval.

Thanks

@engcom-Hotel engcom-Hotel added Progress: on hold Triage: Need PO Confirmation Requirements should be clarified/approved/confirmed with Product Manager. Not ready for fix/delivery and removed Progress: review labels Feb 18, 2025
@engcom-Hotel
Copy link
Contributor

Hello @Mohamed-Asar,

We have received approval on this PR from the PO. Therefore, we will proceed with further activities related to it.

Thanks

@engcom-Hotel engcom-Hotel moved this from On Hold to Review in Progress in Community Dashboard Apr 22, 2025
@Mohamed-Asar
Copy link
Contributor Author

@magento run all tests

@Mohamed-Asar
Copy link
Contributor Author

@magento run Functional Tests B2B, Functional Tests EE, Integration Tests, WebAPI Tests

@Mohamed-Asar
Copy link
Contributor Author

Hello @Mohamed-Asar,

I think if you fix the failed integration test, would be enough for this PR changes. Please have a look and let us know if you have any query.

Thanks

Changes done, please review

@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Changes Requested to Review in Progress in Community Dashboard Apr 29, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Review in Progress to Ready for Testing in Community Dashboard Apr 29, 2025
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in Community Dashboard Apr 30, 2025
@engcom-Bravo
Copy link
Contributor

@magento run all tests

@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot added the Priority: P3 May be fixed according to the position in the backlog. label Apr 30, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Apr 30, 2025
@engcom-Bravo engcom-Bravo moved this to Testing in Progress in Community Dashboard Apr 30, 2025
@engcom-Bravo engcom-Bravo self-assigned this Apr 30, 2025
@engcom-Bravo
Copy link
Contributor

Hi @Mohamed-Asar,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

After: ✔️

Screenshot 2025-04-30 at 2 45 47 pm

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard Apr 30, 2025
@engcom-Bravo engcom-Bravo removed the Priority: P3 May be fixed according to the position in the backlog. label Apr 30, 2025
@engcom-Dash engcom-Dash self-assigned this Apr 30, 2025
@engcom-Dash
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Dash
Copy link
Contributor

In last two builds test failures for Functional Tests B2B are inconsistent and seems to be flaky. They neither part of PR nor failing because of the PR changes.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39570/e3620d08dcf9910b122fcbb01e36c29f/Functional/allure-report-b2b/index.html#categories/bdbf199525818fae7a8651db9eafe741

image

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39570/a5c0582c57ab3005b9daabc9b0427101/Functional/allure-report-b2b/index.html#categories/bdbf199525818fae7a8651db9eafe741

image

Hence moving this PR in Merge in Progress

@engcom-Dash engcom-Dash moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

Assignees

@engcom-Bravo engcom-Bravo

@engcom-Dash engcom-Dash

Labels
Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review Progress: ready for testing Project: Community Picked PRs upvoted by the community
Projects
Community Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Removed email disclosure
7 participants
@Mohamed-Asar @engcom-Hotel @engcom-Bravo @engcom-Dash @m2-github-services @Priyakshic @magento-ct-gh-projects-svc