Skip to content

Commit 849ee33

Browse files
marco-cmarco-c
committed
Bug 1463665 [wpt PR 11115] - [css-grid] Content Alignment as part of the track sizing algorithm, a=testonly
Automatic update from web-platform-tests[css-grid] Content Alignment as part of the track sizing algorithm The CSS WG resolved [1] that Content Alignment should account to the track sizing algorithm. The sizing algorithm has been modified so that two new steps (1.5 and 2.5) were added to compute the Content Alignment offsets after resolving the columns' and rows' sizes respectively. This change decouples the Content Alignment logic from the tracks position, so that we can use it as part of the track sizing algorithm. I also had to store the whole ContentAlignmentData structure in two class attributes. We need both, position and distribution offsets, to be used in different parts of the layout logic. Finally, since the ContentAlignmentData is now used as persistent memory, we had to remove the STACK_ALLOCATED flag; hence, I think using DISALLOW_COPY_AND_ASSIGN and let the functions update the structure's internal field is a more efficient approach to commit this change. [1] w3c/csswg-drafts#2557 Added WPT * grid-content-distribution-must-account-for-track-sizing-001.html * grid-content-distribution-must-account-for-track-sizing-002.html Bug: 844744 Change-Id: I90019a96b148d3713467e35fde9482d0d39b1ced Reviewed-on: https://chromium-review.googlesource.com/1067918 Commit-Queue: Javier Fernandez <jfernandezigalia.com> Reviewed-by: Manuel Rego Casasnovas <regoigalia.com> Cr-Commit-Position: refs/heads/master{#566412} -- wpt-commits: 73ed379a1437407749c730239019bd61528b060b wpt-pr: 11115 UltraBlame original commit: 96df24278a6cbca9a03b0750b55c6fc834ad4742
1 parent 3aa5c66 commit 849ee33

File tree

3 files changed

+1111
-0
lines changed

3 files changed

+1111
-0
lines changed

‎testing/web-platform/meta/MANIFEST.json

Lines changed: 220 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1933486,6 +1933486,146 @@ algorithm
19334861933486
/
19334871933487
grid
19334881933488
-
1933489+
content
1933490+
-
1933491+
distribution
1933492+
-
1933493+
must
1933494+
-
1933495+
account
1933496+
-
1933497+
for
1933498+
-
1933499+
track
1933500+
-
1933501+
sizing
1933502+
-
1933503+
001
1933504+
.
1933505+
html
1933506+
"
1933507+
:
1933508+
[
1933509+
[
1933510+
"
1933511+
/
1933512+
css
1933513+
/
1933514+
css
1933515+
-
1933516+
grid
1933517+
/
1933518+
layout
1933519+
-
1933520+
algorithm
1933521+
/
1933522+
grid
1933523+
-
1933524+
content
1933525+
-
1933526+
distribution
1933527+
-
1933528+
must
1933529+
-
1933530+
account
1933531+
-
1933532+
for
1933533+
-
1933534+
track
1933535+
-
1933536+
sizing
1933537+
-
1933538+
001
1933539+
.
1933540+
html
1933541+
"
1933542+
{
1933543+
}
1933544+
]
1933545+
]
1933546+
"
1933547+
css
1933548+
/
1933549+
css
1933550+
-
1933551+
grid
1933552+
/
1933553+
layout
1933554+
-
1933555+
algorithm
1933556+
/
1933557+
grid
1933558+
-
1933559+
content
1933560+
-
1933561+
distribution
1933562+
-
1933563+
must
1933564+
-
1933565+
account
1933566+
-
1933567+
for
1933568+
-
1933569+
track
1933570+
-
1933571+
sizing
1933572+
-
1933573+
002
1933574+
.
1933575+
html
1933576+
"
1933577+
:
1933578+
[
1933579+
[
1933580+
"
1933581+
/
1933582+
css
1933583+
/
1933584+
css
1933585+
-
1933586+
grid
1933587+
/
1933588+
layout
1933589+
-
1933590+
algorithm
1933591+
/
1933592+
grid
1933593+
-
1933594+
content
1933595+
-
1933596+
distribution
1933597+
-
1933598+
must
1933599+
-
1933600+
account
1933601+
-
1933602+
for
1933603+
-
1933604+
track
1933605+
-
1933606+
sizing
1933607+
-
1933608+
002
1933609+
.
1933610+
html
1933611+
"
1933612+
{
1933613+
}
1933614+
]
1933615+
]
1933616+
"
1933617+
css
1933618+
/
1933619+
css
1933620+
-
1933621+
grid
1933622+
/
1933623+
layout
1933624+
-
1933625+
algorithm
1933626+
/
1933627+
grid
1933628+
-
19334891933629
find
19334901933630
-
19334911933631
fr
@@ -3403933,6 +3404073,86 @@ algorithm
34039333404073
/
34039343404074
grid
34039353404075
-
3404076+
content
3404077+
-
3404078+
distribution
3404079+
-
3404080+
must
3404081+
-
3404082+
account
3404083+
-
3404084+
for
3404085+
-
3404086+
track
3404087+
-
3404088+
sizing
3404089+
-
3404090+
001
3404091+
.
3404092+
html
3404093+
"
3404094+
:
3404095+
[
3404096+
"
3404097+
3be009e32e61d1748dcb64aab0110c8c38e06b15
3404098+
"
3404099+
"
3404100+
testharness
3404101+
"
3404102+
]
3404103+
"
3404104+
css
3404105+
/
3404106+
css
3404107+
-
3404108+
grid
3404109+
/
3404110+
layout
3404111+
-
3404112+
algorithm
3404113+
/
3404114+
grid
3404115+
-
3404116+
content
3404117+
-
3404118+
distribution
3404119+
-
3404120+
must
3404121+
-
3404122+
account
3404123+
-
3404124+
for
3404125+
-
3404126+
track
3404127+
-
3404128+
sizing
3404129+
-
3404130+
002
3404131+
.
3404132+
html
3404133+
"
3404134+
:
3404135+
[
3404136+
"
3404137+
7498215ab49c60cad188cfb634ed435079b96a06
3404138+
"
3404139+
"
3404140+
testharness
3404141+
"
3404142+
]
3404143+
"
3404144+
css
3404145+
/
3404146+
css
3404147+
-
3404148+
grid
3404149+
/
3404150+
layout
3404151+
-
3404152+
algorithm
3404153+
/
3404154+
grid
3404155+
-
34039363404156
find
34039373404157
-
34039383404158
fr

0 commit comments

Comments
 (0)