Improve Network Information #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes from ip-api, either ISP or ASN is available, but it would not show since the condition is not satisfied. Fix to show if either value is present
|
Weird that there is some spacing issue on the PR.
|
|
Convert spaces to tabs and that should fix the spacing issue. |
|
Thanks for the suggestion @masonr , that fixed it! |
|
This PR was merged a few days ago, but I have just removed the Biznet (Jakarta, ID) iperf3 server from the list. I've had this particular one added before and it was never very stable. After noticing many failures on that location the since the merge, I decided to pull it again. Some of the ports weren't responding, IPv6 wasn't working to that location, uptime isn't that great -- will be looking for another location in the region use instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes from ip-api, either ISP or ASN is available, but it would not show since the condition is not satisfied. Fix to show if either value is present.
Also added an Asian location (Jakarta, ID) to iperf test.