-
-
Notifications
You must be signed in to change notification settings - Fork 96
Usage of reduce spread #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I assume you mean schester44@7caf8a1. I like it. I think you should PR! Comments so far:
|
I'll go ahead and continue with this and create PR soon. |
There could be noticeable perf improvements if we were to stop using the reduce spread pattern in the diffing methods.
Some benchmarks from changing the
diff
method to use basic for loops:original x 377,694 ops/sec ±0.62% (86 runs sampled)
new x 788,699 ops/sec ±0.55% (91 runs sampled)
Reference: https://www.richsnapp.com/blog/2019/06-09-reduce-spread-anti-pattern
I have most of the work done in a fork. Would you be open to a PR?
The text was updated successfully, but these errors were encountered: