Skip to content

Use ECMAScript modules instead of CommonJS modules #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rallets opened this issue Aug 21, 2020 · 3 comments
Closed

Use ECMAScript modules instead of CommonJS modules #57

rallets opened this issue Aug 21, 2020 · 3 comments

Comments

@rallets
Copy link

rallets commented Aug 21, 2020

Hi, building an Angular project with the latest version 10.0.7 I got this warning message
WARNING in C:[...]\filename.ts depends on 'deep-object-diff'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Is there any chance this library to be convert to ECMAScript modules? This will allow for a greater bundle size optimization at build time for apps that uses webpack or similar minifiers (https://web.dev/commonjs-larger-bundles/).

Thanks

@mattphillips
Copy link
Owner

Sorry to come to so long after you raised the issue @rallets!

I've just played with publishing the module with ES module support - would be great if you (or anyone) could confirm it's working. Should be available in v1.1.5

@rallets
Copy link
Author

rallets commented Jan 25, 2022

Hi @mattphillips, great to hear you published a new version.
Unfortunately I'm not working anymore on that project, so I don't have access to the source code to test it's working as it should.

@mattphillips
Copy link
Owner

@rallets no worries at all - I just did a manual test with node and it seems to be OK.

I'll close this issue for now and if anyone runs into this issue again then feel free to comment or PR a fix 😅

Thanks for your quick reply @rallets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants