Skip to content

Commit 5f4d9ae

Browse files
author
marcel corso gonzalez
authored
Merge pull request #61 from mehmetminanc/encoding-fix
Some encoding fixes
2 parents 92ce5cc + bd995a4 commit 5f4d9ae

File tree

3 files changed

+18
-3
lines changed

3 files changed

+18
-3
lines changed

messagebird/http_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def request(self, path, method='GET', params=None, format=ResponseFormat.text):
3030
'Accept': 'application/json',
3131
'Authorization': 'AccessKey ' + self.access_key,
3232
'User-Agent': self.user_agent,
33-
'Content-Type': 'application/json'
33+
'Content-Type': 'application/json; charset=UTF-8'
3434
}
3535

3636
method_switcher = {

messagebird/serde.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33

44
def json_serialize(obj):
55
try:
6-
return json.dumps(obj)
6+
return json.dumps(obj, ensure_ascii=False).encode('utf-8')
77
except TypeError:
8-
return json.dumps(obj, default=lambda o: o.__dict__)
8+
return json.dumps(obj, default=lambda o: o.__dict__, ensure_ascii=False).encode('utf-8')

tests/test_serde.py

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# coding=utf-8
2+
import unittest
3+
4+
from messagebird.serde import json_serialize
5+
6+
7+
class TestJSONSerDe(unittest.TestCase):
8+
9+
def test_tr_check(self):
10+
self.assertEqual(json_serialize({'body': 'Pijamalı hasta, yağız şoföre çabucak güvendi.'}),
11+
"""{"body": "Pijamalı hasta, yağız şoföre çabucak güvendi."}""".encode("utf-8"))
12+
13+
def test_jp_check(self):
14+
self.assertEqual(json_serialize({'body': 'いろはにほへとちりぬるを'}),
15+
"""{"body": "いろはにほへとちりぬるを"}""".encode("utf-8"))

0 commit comments

Comments
 (0)