Skip to content

Commit fa6929f

Browse files
FxKuFelix Kunde
andauthored
do not block rolling updates with lazy spilo update enabled (zalando#1012)
* do not block rolling updates with lazy spilo update enabled * treat initContainers like Spilo image Co-authored-by: Felix Kunde <[email protected]>
1 parent fe7ffaa commit fa6929f

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

docs/reference/operator_parameters.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ Those are top-level keys, containing both leaf keys and groups.
7676
The default is `true`.
7777

7878
* **enable_lazy_spilo_upgrade**
79-
Instruct operator to update only the statefulsets with the new image without immediately doing the rolling update. The assumption is pods will be re-started later with the new image, for example due to the node rotation.
79+
Instruct operator to update only the statefulsets with new images (Spilo and InitContainers) without immediately doing the rolling update. The assumption is pods will be re-started later with new images, for example due to the node rotation.
8080
The default is `false`.
8181

8282
* **etcd_host**

pkg/cluster/cluster.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,6 @@ func (c *Cluster) compareStatefulSetWith(statefulSet *appsv1.StatefulSet) *compa
488488
// until they are re-created for other reasons, for example node rotation
489489
if c.OpConfig.EnableLazySpiloUpgrade && !reflect.DeepEqual(c.Statefulset.Spec.Template.Spec.Containers[0].Image, statefulSet.Spec.Template.Spec.Containers[0].Image) {
490490
needsReplace = true
491-
needsRollUpdate = false
492491
reasons = append(reasons, "lazy Spilo update: new statefulset's pod image doesn't match the current one")
493492
}
494493

0 commit comments

Comments
 (0)