Skip to content

Conversation

@564612540
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs change / refactoring / dependency upgrade

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 22, 2025
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.)

@iden-kalemaj
Copy link
Contributor

Thank you for adding the copyright.

Please see the lint errors here: https://github.com/pytorch/opacus/actions/runs/12958861076/job/36150080849?pr=719

@iden-kalemaj iden-kalemaj self-assigned this Jan 24, 2025
@564612540
Copy link
Contributor Author

I think the issues are resolved

@iden-kalemaj iden-kalemaj self-requested a review March 10, 2025 16:09
Copy link
Contributor

@iden-kalemaj iden-kalemaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

There is still some linting issues, but I can take care of fixing them after merging to speed up the process.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in f23e5c4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants