Skip to content

Empty author links in sidebar #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
oalders opened this issue Sep 29, 2022 · 1 comment · May be fixed by #3342
Open

Empty author links in sidebar #2750

oalders opened this issue Sep 29, 2022 · 1 comment · May be fixed by #3342
Labels
design-2022-followup type:Bug

Comments

@oalders
Copy link
Member

oalders commented Sep 29, 2022

For example: https://metacpan.org/author/JGNI

Screen Shot 2022-09-29 at 15 17 09

This author has a GitHub section in their profile with an empty id: https://explorer.metacpan.org/?url=/author/JGNI

Normally the pin would have a location name beside it. In this author's case, there are lon/lat co-ordinates. So, we need to fix how we handle that here.
@haarg haarg mentioned this issue Sep 30, 2022
Merged
@haarg
Copy link
Member

haarg commented Sep 30, 2022

Previously, we were showing a flag for the country, so even if no other location data was provided, the flag would be useful. Now, it's showing a generic icon.

The listed country in this case is uk. That isn't even a proper ISO code. The ISO 3166 code for the United Kingdom is gb. Previously we just had a set of images for the flags, and both of these were supported.

I'm not sure what the best solution is here. We could try to convert the country code to a country name, but even if we had a valid code in this case, the country name is "United Kingdom of Great Britain and Northern Ireland", which gets rather awkward to display in the sidebar.

The GitHub link is a separate issue, which I've filed a PR for.

oalders added a commit that referenced this issue May 3, 2025
@oalders
Add an author flag to the sidebar
30a55c5 
This fixes a display issue when the author has a country set, but no
city or region. Closes #2750
@oalders oalders linked a pull request May 3, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design-2022-followup type:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add an author flag to the sidebar metacpan/metacpan-web
2 participants
@haarg @oalders