-
Notifications
You must be signed in to change notification settings - Fork 6
vcp: normalize timezone offset #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Relevant from this comment #27 (comment)
|
Testing current parsers: <div class="h-event">
<h1 class="p-name">Happy 17th birthday microformats.org</h1>
<p class="dt-start">
<time class="value" datetime="2022-06-20">20 June</time>, from
<time class="value">00:00-08:00</time>
</p>
</div> Normalizes timezone offset as described above:
|
sounds reasonable to me (+1 with hat as mf2py contributor) |
The working JS parser: https://github.com/microformats/microformats-parser |
Throwing in the Rust parser into the mix at https://rust.microformats.io, it defaults to adding colons in offsets if they were provided initially. (Originally published at: https://jacky.wtf/2022/6/S0Jx) |
(+1) I'm in favor of the change of normalizing the timezone offset such that the colon is not present. The Rust implementation is currently capable of checking if it was there when it was authored. If it's either always or not present, there's a bit of logic I can remove (less code is good). (Originally published at: https://jacky.wtf/2022/6/Kwm5) |
Resolution: proposal accepted. No objections in above discussion, 4 parsers already implement it, and positive opinions (+1) from a few implementers on the proposal. Updated spec with this revision: https://microformats.org/wiki/index.php?title=value-class-pattern&oldid=70522 |
In https://microformats.org/wiki/value-class-pattern#Date_and_time_parsing
Reference:
Change the later line:
To:
XX:YY
format, remove the colon so it isXXYY
format. This makes it less likely that a timezone offset will be confused for a time.The final two bullets in this section seem to imply this behavior by the two timezone examples not including colons. This suggested spec change will make it explicit and also let us resolve microformats/tests#29.
The text was updated successfully, but these errors were encountered: