Skip to content

Resolve relative URLs inside e-* properties? #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
barnabywalters opened this issue May 13, 2013 · 5 comments
Closed

Resolve relative URLs inside e-* properties? #16

barnabywalters opened this issue May 13, 2013 · 5 comments

Comments

@barnabywalters
Copy link
Collaborator

Should we do this? Seems like a no-brainer but there may be implications I have not considered.

@aaronpk
Copy link
Member

aaronpk commented May 13, 2013

Assuming you mean resolving things like "../logo.jpg" to "http://tantek.com/logo.jpg" then yes I fully support this idea :) I think it will require the addition of the base URL to the parsing function since currently the only input is HTML

@barnabywalters
Copy link
Collaborator Author

@aaronpk thanks, I’ll go ahead and implement this.

RE “only input is HTML”: not so https://github.com/indieweb/php-mf2/blob/master/mf2/Parser.php#L35

@aaronpk
Copy link
Member

aaronpk commented May 14, 2013

Great! You're one step ahead of me!

@barnabywalters
Copy link
Collaborator Author

To be fair I did write the library :)

@barnabywalters
Copy link
Collaborator Author

Closed with 64539a0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants