Skip to content

uasyncio.websocket.server compatibility with websocket clients #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pidou46 opened this issue Sep 25, 2019 · 0 comments
Open

uasyncio.websocket.server compatibility with websocket clients #355

pidou46 opened this issue Sep 25, 2019 · 0 comments

Comments

@pidou46
Copy link

pidou46 commented Sep 25, 2019

server.py does not work with every clients. For instance CPython websockets client https://pypi.org/project/websockets/

I have made some experiments https://forum.micropython.org/viewtopic.php?f=15&t=6568&p=37374#p37374 and found that there is already some modifications to uncomment to enable compatibility with this client, plus pycopy port unable this modifications, with some explanation in the last PR. https://github.com/pfalcon/pycopy-lib/commit/3803ff6ad7156dee9575f1c921f4df3fa2bdc117

Is there a reason why it is not enabled ? does it broke compatibility with some other client ?
In this case could it be possible to selectively enable it depending the connected client?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant