aioble: Improve handling of descriptors. #517
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jimmo
commented
Aug 9, 2022
jimmo
commented
- Use the characteristic end handle (available in next MicroPython release) when querying descriptors. Fixes Aioble - Discover duplicated or unrelated descriptors #485
- Fix server-side custom descriptor registration. Fixes Issue in AIOBLE #442
- Fix descriptor client events.
- Add multi-test.
jimmo
force-pushed
the
aioble-descriptors
branch
from
a1f7680 to
6ec2ec6
Compare
|
See corresponding change in micropython/micropython#9031 |
The `bluetooth` module replaced the def_handle field with end_handle in the characteristic result IRQ. Use this when querying for descriptors. In the case where this is not available (older versions of micropython) continue the existing behavior of searching just past the value handle, although decrease this to +2 to avoid finding other characteristic's descriptors. Signed-off-by: Jim Mussared <[email protected]>
This allows a server to register descriptors, which was previously not fully implemented. Signed-off-by: Jim Mussared <[email protected]>
Descriptors were missing common initialisation for events shared with characteristics. Signed-off-by: Jim Mussared <[email protected]>
Signed-off-by: Jim Mussared <[email protected]>
jimmo
force-pushed
the
aioble-descriptors
branch
from
6ec2ec6 to
9e189da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.