Skip to content

mip: github branch is incorrectly used for secondary github: sources in package.json #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ned-pcs opened this issue Jun 12, 2023 · 0 comments

Comments

@ned-pcs
Copy link

ned-pcs commented Jun 12, 2023

mip version 0.2.0

When you specify a version to mip.install() to reference a particular GitHub branch, this branch is used for every github: source in the package.json, even those coming from a different repository.

The best solution to this is probably:

  • provide a way (perhaps an optional third field) for a URL to specify a different branch
  • default the branch to HEAD for secondary github: urls if they don't provide an explicit branch

In my PR #676 I have done the second part of this (default to HEAD) but not the first part yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant