Skip to content

utarfile: sanitize file size bytearray #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

utarfile: sanitize file size bytearray #685

wants to merge 1 commit into from

Conversation

AuHau
Copy link

@AuHau AuHau commented Jun 17, 2023

Fixes #684

Not sure if it is correct way how to handle it, but it works for me 😅

massimosala
massimosala suggested changes Jun 28, 2023
View reviewed changes
Copy link

@massimosala massimosala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent with h.name sanitizing, I suggest you to remove the .replace() and use

h.size.rstrip("\0")

@dpgeorge
Copy link
Member

Fixed instead by 0a5b635

@dpgeorge dpgeorge closed this Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@massimosala massimosala massimosala requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

utarfile: invalid syntax for integer with base 8
3 participants
@AuHau @dpgeorge @massimosala