Skip to content

requests do not works in mutithread, breaks the whole script/device #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barart opened this issue Nov 27, 2023 · 0 comments
Open

requests do not works in mutithread, breaks the whole script/device #772

barart opened this issue Nov 27, 2023 · 0 comments

Comments

@barart
Copy link

barart commented Nov 27, 2023

A simple script like this, breaks the whole script or device when trying to make requests from two works ¿? I dont know exactly how to call the problem but you can replicate it easily.

Im using MicroPython v1.21.0 on 2023-10-06; Raspberry Pi Pico W with RP2040

The main loop can work fine forever (pinging the url) but as soon as i press the button it breaks with this random behaviors:

  1. Main loop requests hangs and remains until timeout, i can raise timeout to hours and request still hanged forever, 2nd thread request go out fine for one time but if i press button again it just hangs too and it just hangs forever until reboot device
  2. Main loop request hangs forever and button requests works fine every-time i press button
  3. Button requests pass fine for one time, then it hangs but Main loop request works fine forever

I have been trying to make it works for 1 week and it just don work, what i tried:

Using thread.allocate_lock()
Making two request functions (one for main loop one for button press request)
make a clone of request library and import it with a different name, then calling the requests library from main loop and the cloned library from button request
using other gpio button (not the bootsel button)
use the 2nd thread function without button (making it automatically with a sleep times)

All tries ended on the same problem, also i have use a longer sleep times for the main loop and press the button to call the request function some minutes after the main loop ended and it do the same

It seems (at my poor knowledge on python) that requests library do not "release" (or close) at all the requests and it leave only available for the first core that use it?

How can i make it works with this two threads functions?

import utime, _thread, ujson, requests, network

ssid_name = 'xxx'
ssid_pass = 'xxx'
wlan = network.WLAN(network.STA_IF)
wlan.active(True)

def make_http_request(url):
    print("request entry")
    r = None
    response_data = None
    try:
        print("trying block")
        r = requests.get(url, timeout=10)
        response_data = ujson.loads(r.text)
        r.close()
        return response_data
    except Exception as e:
        print("Error:", e)
        raise
    finally:
        if r is not None:
            r.close()
                
def bootsel():
    import rp2
    while True:
        if rp2.bootsel_button() == 1:
            print("pressed")
            but_data = make_http_request("https://httpbin.org/get")
            print(f"But: {but_data}")

_thread.start_new_thread(bootsel,())
while True:
    if wlan.isconnected():
        print("connected.. pinging")
        ping = make_http_request("https://httpbin.org/get")
        print(f"Ping: {ping}")
        print("sleeping")
        utime.sleep(45)
    else:
        time=0
        while not wlan.isconnected():
            print ('connecting...')
            wlan.connect(ssid_name, ssid_pass)
            while not wlan.isconnected():
                time = time + 1
                print(f'waiting connection {time}')
                utime.sleep_ms(1000)

@barart barart changed the title requests do not works in mutithread, breaks the whole script requests do not works in mutithread, breaks the whole script/device Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant