Skip to content

Commit ae57903

Browse files
🐛 Add missing link references for "God Objects" and Ternary enum definition (#3)
* 🐛 Fix missing link reference to "God Objects" Signed-off-by: Babak K. Shandiz <[email protected]> * 🐛 Add missing link references for `Ternary` enum definition Signed-off-by: Babak K. Shandiz <[email protected]> * Update codebase/src/compiler/checker.md Co-authored-by: Holger Jeromin <[email protected]> --------- Signed-off-by: Babak K. Shandiz <[email protected]> Co-authored-by: Holger Jeromin <[email protected]>
1 parent 4c984c5 commit ae57903

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

codebase/src/compiler/checker.md

+4
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ Switching to different files means probably making [god objects][god], and the c
1717
We want to avoid additional calls for ambient context. There are architectural patterns for this, but it's better
1818
to assume good faith that they've been explored already (8 years down the line now.)
1919
20+
[god]: https://en.wikipedia.org/wiki/God_object
21+
2022
Anyway, better to get started somewhere. I [asked online](https://twitter.com/orta/status/1148335807780007939)
2123
about how people would try to study a file like this and I think one of the best paths is by following a
2224
particular story as a file gets checked.
@@ -225,4 +227,6 @@ TODO: what are substituted types?
225227
[22]: <src/compiler/checker.ts - function eachTypeRelatedToSomeType>
226228
[23]: https://github.com/microsoft/TypeScript/blob/db9e0079/src/compiler/checker.ts#L18872
227229
[23]: <src/compiler/checker.ts - function structuredTypeRelatedTo>
230+
[24]: https://github.com/microsoft/TypeScript/blob/eb430f27/src/compiler/types.ts#L6097
231+
[24]: <src/compiler/types.ts - export const enum Ternary>
228232
<!-- prettier-ignore-end -->

0 commit comments

Comments
 (0)