Skip to content

Publish @types/webworker? #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saschanaz opened this issue Feb 3, 2023 · 7 comments · Fixed by #1965
Closed

Publish @types/webworker? #1492

saschanaz opened this issue Feb 3, 2023 · 7 comments · Fixed by #1965

Comments

@saschanaz
Copy link
Contributor

export const packages = [
{
name: "@types/web",
description: "Types for the DOM, and other web technologies in browsers",
readme: "./readmes/web.md",
files: [
{ from: "../generated/dom.generated.d.ts", to: "index.d.ts" },
{ from: "../generated/dom.iterable.generated.d.ts", to: "iterable.d.ts", autoImport: true },
],
},
{
name: "@types/serviceworker",
description: "Types for the global scope of Service Workers",
readme: "./readmes/serviceworker.md",
files: [
{ from: "../generated/serviceworker.generated.d.ts", to: "index.d.ts" },
{ from: "../generated/serviceworker.iterable.generated.d.ts", to: "iterable.d.ts", autoImport: true },
],
},
{
name: "@types/audioworklet",
description: "Types for the global scope of Audio Worklets",
readme: "./readmes/audioworklet.md",
files: [
{ from: "../generated/audioworklet.generated.d.ts", to: "index.d.ts" },
{ from: "../generated/audioworklet.iterable.generated.d.ts", to: "iterable.d.ts", autoImport: true },
],
},
{
name: "@types/sharedworker",
description: "Types for the global scope of Shared Workers",
readme: "./readmes/sharedworker.md",
files: [
{ from: "../generated/sharedworker.generated.d.ts", to: "index.d.ts" },
{ from: "../generated/sharedworker.iterable.generated.d.ts", to: "iterable.d.ts", autoImport: true },
],
},
];

Only shared/serviceworker have the packages but not the dedicated worker.

@HolgerJeromin
Copy link
Contributor

ref #1482 ?

@orta
Copy link
Contributor

orta commented Feb 3, 2023

I did a look through the commits and I don't see a reason why it wasn't generated - there might be debate inside teams ( @sandersn could you maybe search for "@types/webworker" ? ) but otherwise I think it's fine to add.

Maybe I just forgot that one package?

@sandersn
Copy link
Member

sandersn commented Feb 3, 2023

@orta Here's the only comment on Teams, from you on 9 July 2021:

I've set up the rest of the @types/web* packages to the lib-dom-generator. The repo will ship @types/web (DOM + essentials) @types/sharedworker (used by extensions) @types/webworkers ("threads" for JavaScript) @types/serviceworkers (the abstraction PWAs use to redirect HTTP calls) and @types/audioworklets (Audio processing BG threads)

So at the time you said you set it up, at least.

@orta
Copy link
Contributor

orta commented Feb 3, 2023

Thanks sire! Yeah, I'd say that's an omission, adding the new package would require someone from the TS team to accept but we should do that

@jozefchutka
Copy link

As of now, there is no straightforward way to define standard webworker project using TypeScript-DOM-lib-generator. Considering this repo is the main one to use for typescript projects in general, please consider resolving the outstanding issues asap so we can use @types/webworker (+ @typescript/lib-webworker) as a dependency and have a simple configuration in tsconfig.lib.

@Bashamega
Copy link
Contributor

Hello @saschanaz
Is this issue still open? If yes I will open a pr :)

@saschanaz
Copy link
Contributor Author

Please feel free!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants