Skip to content

RadioNodeList should extend NodeListOf<HTMLInputElement> #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ARitz-Cracker opened this issue Jul 30, 2024 · 2 comments · Fixed by #2002
Closed

RadioNodeList should extend NodeListOf<HTMLInputElement> #1766

ARitz-Cracker opened this issue Jul 30, 2024 · 2 comments · Fixed by #2002

Comments

@ARitz-Cracker
Copy link

RadioNodeList currently extend NodeList, while this is technically correct, the items of said node list (as far as I'm aware) are guaranteed to be the radio buttons themselves, which are of type HTMLInputElement. This would eliminate an as when interacting with the properties of the radio buttons, e.g. checked.
@Bashamega
Copy link
Contributor

Should i work on this @saschanaz ?

@saschanaz
Copy link
Contributor

This sounds right. 👍🏻

@Bashamega Bashamega mentioned this issue Apr 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RadioNodeList should extend NodeListOf<HTMLInputElement> Bashamega/TypeScript-DOM-lib-generator
3 participants
@saschanaz @ARitz-Cracker @Bashamega