Skip to content

Commit 1d0af97

Browse files
ATA: node: module resolution (#3191)
Co-authored-by: Jake Bailey <[email protected]>
1 parent ce2f2e9 commit 1d0af97

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

.changeset/plenty-deers-visit.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@typescript/ata": patch
3+
---
4+
5+
Always treat `node:` modules as Node, expand list of known Node modules

packages/ata/src/edgeCases.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ export const mapModuleNameToModule = (moduleSpecifier: string) => {
2424
"http2",
2525
"https",
2626
"inspector",
27+
"inspector/promises",
2728
"module",
2829
"net",
2930
"os",
@@ -57,7 +58,7 @@ export const mapModuleNameToModule = (moduleSpecifier: string) => {
5758
"zlib",
5859
]
5960

60-
if (builtInNodeMods.includes(moduleSpecifier.replace("node:", ""))) {
61+
if (moduleSpecifier.indexOf("node:") === 0 || builtInNodeMods.includes(moduleSpecifier)) {
6162
return "node"
6263
}
6364

packages/ata/tests/edgeCases.spec.ts

+5
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@ describe(mapModuleNameToModule, () => {
99
expect(mapModuleNameToModule("node:fs")).toEqual("node")
1010
})
1111

12+
it("handles mandatorily-prefixed node: identifiers", () => {
13+
expect(mapModuleNameToModule("node:test")).toEqual("node")
14+
expect(mapModuleNameToModule("test")).toEqual("test")
15+
})
16+
1217
it("strips module filepaths", () => {
1318
expect(mapModuleNameToModule("lodash/identity")).toEqual("lodash")
1419
expect(mapModuleNameToModule("@org/lodash/identity")).toEqual("@org/lodash")

0 commit comments

Comments
 (0)