-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Typescript crashes in VS Code insiders latest build with all extensions disabled and TypeScript Nightly extension #52353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
setting this in
in every package in the monorepo should help? |
Would you be able to provide us with a TSServer log from VS Code? To do this, you'd need to:
⚠ Warning: A TSServer log may include information from your workspace, including file paths and source code. If you have any concerns about posting this publicly on GitHub, let us know and you can share the details privately. |
@DanielRosenwasser Hi! |
Sure, email Myfirstname dot Mylastname at microsoft dot com (capitalization unfortunately matters) |
Just to clarify, this is more of a suspiciously long-running thing/a startup hang - it's not causing an actual crash, right? |
Yes, VSCode itself is not crashing, just TS features stop working after this happens, sometimes an error message pops with the message
|
Just to clarify, all our development team that works on that repo (the main monorepo of the company) suffers from it, TS crashes few times a day. |
@DanielRosenwasser did you get the email? |
@bennyk8y can you please try with latest vscode and nightly and see if this still repros and if yes please share the verbose log and way to repro this to investigate this. Thanks |
Hi, I am using the latest VSCODE and typescript constantyl crashes in my monorepo. It works flawlesly with other non monorepo projects. I followed your instructions, but the TS Log even after few minutes is huge. I scanned it and this is the error that keep repeating:
I can give you priveate access to my repo if needed. I would love to see where the error might originate ? |
it seems like some plugin you have thats not handling things correctly as i dont see why you should run into this as its guarded correctly. TypeScript/src/services/services.ts Line 1683 in 3163fe7
|
Getting this same error:
Typescript v5.6.2 The file content where it fails: import { CopyButton } from "@/components/CopyButton";
import { TableList, type TableListItemProps } from "@/components/TableList";
import { TextLink } from "@/components/TextLink";
import { CodeEditor } from "@/components/inputs/CodeEditor";
import { useUser } from "@/features/account/hooks/useUser";
import { DataVariableInputs } from "@/features/blocks/integrations/httpRequest/components/ResponseMappingInputs";
import { getDeepKeys } from "@/features/blocks/integrations/httpRequest/helpers/getDeepKeys";
import { useTypebot } from "@/features/editor/providers/TypebotProvider";
import {
Accordion,
AccordionButton,
AccordionIcon,
AccordionItem,
AccordionPanel,
Button,
FormControl,
FormHelperText,
Input,
InputGroup,
InputRightElement,
Stack,
Tab,
TabList,
TabPanel,
TabPanels,
Tabs,
Text,
} from "@chakra-ui/react";
import type { ResponseVariableMapping } from "@typebot.io/blocks-integrations/httpRequest/schema";
import type { WebhookBlock } from "@typebot.io/blocks-logic/webhook/schema";
import { env } from "@typebot.io/env";
import usePartySocket from "partysocket/react";
import { useMemo, useState } from "react";
type Props = {
blockId: string;
options: WebhookBlock["options"];
onOptionsChange: (options: WebhookBlock["options"]) => void;
};
export const WebhookSettings = ({
blockId,
options,
onOptionsChange,
}: Props) => {
const { typebot } = useTypebot();
const { user } = useUser();
const [receivedData, setReceivedData] = useState<string>();
const [websocketStatus, setWebsocketStatus] = useState<"closed" | "opened">(
"closed",
);
const [responseKeys, setResponseKeys] = useState<string[]>([]);
const updateResponseVariableMapping = (
responseVariableMapping: ResponseVariableMapping[],
) => onOptionsChange({ ...options, responseVariableMapping });
const ws = usePartySocket({
host: env.NEXT_PUBLIC_PARTYKIT_HOST,
room: `${user?.id}/${typebot?.id}/webhooks`,
onMessage(e) {
setReceivedData(e.data);
setResponseKeys(getDeepKeys(JSON.parse(e.data)));
setWebsocketStatus("closed");
ws.close();
},
onError(e) {
console.log("error", e);
},
startClosed: true,
});
const listenForTestEvent = () => {
ws.reconnect();
setWebsocketStatus("opened");
};
const ResponseMappingInputs = useMemo(
() =>
function Component(props: TableListItemProps<ResponseVariableMapping>) {
return <DataVariableInputs {...props} dataItems={responseKeys} />;
},
[responseKeys],
);
const urlBase = typebot
? `${env.NEXT_PUBLIC_VIEWER_URL[0]}/api/v1/typebots/${typebot.id}/blocks/${blockId}/executeWebhook`
: "";
return (
<Stack>
<Tabs size="sm" isFitted variant="">
<TabList>
<Tab>Test URL</Tab>
<Tab>Production URL</Tab>
</TabList>
<TabPanels>
<TabPanel>
{typebot && (
<FormControl as={Stack}>
<InputGroup size="sm">
<Input type={"text"} defaultValue={urlBase} />
<InputRightElement width="60px">
<CopyButton size="sm" textToCopy={urlBase} />
</InputRightElement>
</InputGroup>
</FormControl>
)}
</TabPanel>
<TabPanel>
{typebot && (
<FormControl as={Stack}>
<InputGroup size="sm">
<Input
type={"text"}
defaultValue={`${urlBase}/<result_id>`}
/>
<InputRightElement width="60px">
<CopyButton
size="sm"
textToCopy={`${urlBase}/<result_id>`}
/>
</InputRightElement>
</InputGroup>
<FormHelperText mt="0">
You can easily get the Result ID{" "}
<TextLink
isExternal
href="https://docs.typebot.io/editor/blocks/logic/set-variable#result-id"
>
with a Set variable block
</TextLink>
.
</FormHelperText>
</FormControl>
)}
</TabPanel>
</TabPanels>
</Tabs>
<Button
onClick={listenForTestEvent}
colorScheme="blue"
isLoading={websocketStatus === "opened"}
>
Listen for test event
</Button>
{websocketStatus === "opened" && (
<Stack borderWidth="1px" p="4" borderRadius="md" spacing="3">
<Text fontSize="sm">
Waiting for an{" "}
<TextLink
href={"https://docs.typebot.io/api-reference/authentication"}
isExternal
>
authenticated
</TextLink>
POST request to the Test URL...
</Text>
</Stack>
)}
{receivedData && (
<CodeEditor isReadOnly lang="json" value={receivedData} />
)}
{(receivedData ||
(options?.responseVariableMapping &&
options.responseVariableMapping.length > 0)) && (
<Accordion allowMultiple>
<AccordionItem>
<AccordionButton justifyContent="space-between">
Save in variables
<AccordionIcon />
</AccordionButton>
<AccordionPanel pt="4">
<TableList<ResponseVariableMapping>
initialItems={options?.responseVariableMapping}
onItemsChange={updateResponseVariableMapping}
addLabel="Add an entry"
>
{(props) => <ResponseMappingInputs {...props} />}
</TableList>
</AccordionPanel>
</AccordionItem>
</Accordion>
)}
</Stack>
);
}; This happens when I try to trigger the autocomplete drodown on in |
Hi! Have the same problem.
|
@bennyk8y did you get a fix on that? I'm still facing this on Zed Editor with typescript I often have to restart the Typescript server for it to get back on
|
Hi, in our company we are working in relatively big TS monorepo.
For all our developers TS crashes few times a day.
My setup:
Another thing that we've tried is excluding from File Watcher
node_modules/**
andnode_modules
but i see its still being watched under, but i guess its a different thing.Bug Report
🔎 Search Terms
typescript crash, typescript plugin loading infinitely
🕗 Version & Regression Information
The indications for this crash are
The text was updated successfully, but these errors were encountered: