Invertibility for unchecked pointers #1127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 13, 2021 13:34
sulekhark
approved these changes
Jul 14, 2021
| // Original value of i in i - 1: x | ||
| // Updated EquivExprs: { { x - 1, i } }, Updated SameValue: { i + 1 } | ||
| // Original value of i in i - 1: i + 1 | ||
| // Updated EquivExprs: { { i + 1, i } }, Updated SameValue: { i + 1 } |
There was a problem hiding this comment.
Looks like there is a typo here: the updated equivalent expressions must be {i+1, x}.
…into invertibility-unchecked-pointers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1123
This PR allows pointer arithmetic expressions with unchecked pointer type to be invertible. This means that unchecked pointers with bounds-safe interfaces in unchecked scopes can have inverses.
For example:
In the body of
f,phas the unchecked pointer typeint *since it is in an unchecked scope. Before this PR,pwould have no inverse in the expressionp + 1. After this PR,phas the inversep - 1.