-
Notifications
You must be signed in to change notification settings - Fork 79
Simple normalizations for +1/-1 bounds scenarios #1128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dths methods from BaseRange and call utility methods instead
… already in the output form
…into plus-one-minus-one-bounds-widening
sulekhark
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
mgrang
approved these changes
Jul 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements some transformation functions to enable the bounds checker to validate some additional bounds.
These normalization functions attempt to express a given upper bound expression as
((E1 + E2) +/- A) +/- B
, whereE1
has pointer type andA
andB
are integer constants. The bounds checker can use the variable partE1 + E2
and the constant partA + B
to compare bounds expressions.This enables the bounds checker to validate certain bounds that can arise in bounds widening scenarios. For example:
The bounds checker can express the inferred upper bound
(p + (len - 1)) + 1)
as ((p + len) - 1) + 1and extract the variable part
p + lenand the constant part
-1 + 1 == 0. The bounds checker can then use these to prove that the inferred upper bound is equivalent to the declared upper bound
p + len`.