Skip to content

workspace.workspaceFolders client capability missing dynamic registration support #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MariaSolOs opened this issue Apr 28, 2025 · 3 comments · May be fixed by microsoft/vscode-languageserver-node#1627 or #2134
Labels
info-needed Issue requires more information from poster

Comments

@MariaSolOs
Copy link
Contributor

The protocol currently specifies that the workspace.workspaceFolders client capability is simply a boolean, but then it isn't clear how a server can tell whether an editor supports dynamic registration for the workspace/didChangeWorkspaceFolders notification.

@MariaSolOs
Copy link
Contributor Author

MariaSolOs commented Apr 28, 2025

In fact, it isn't clear which client capability maps to the workspace/didChangeWorkspaceFolders request. Based on the VS Code implementation it seems that editors that supports workspace/workspaceFolders should also support workspace/didChangeWorkspaceFolders (?).

@dbaeumer
Copy link
Member

dbaeumer commented May 5, 2025

Yes, this was always the assumption. If a client supports workspace folder it supports change notifications. I would like to keep it that way and rather doc in the spec since changing this might break existing servers.

@MariaSolOs
Copy link
Contributor Author

Yes, this was always the assumption. If a client supports workspace folder it supports change notifications. I would like to keep it that way and rather doc in the spec since changing this might break existing servers.

Okay I understand that, but there's still no information in the client's capabilities about dynamic registration support for the workspace/didChangeWorkspaceFolders notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster
Projects
None yet
2 participants