feat: support flex clusters to atlas tools #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmenezes
changed the title
fmenezes
force-pushed
the
fmenezes/add_flex_clusters
branch
from
ceba258 to
6b0d393
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for flex clusters in atlas tools by updating the cluster API calls, merging flex and traditional cluster data in the lists, and updating the filtering of operations.
- Merges flex clusters with traditional clusters in the listClusters tool
- Updates inspectCluster and connectCluster to use the new inspectCluster helper
- Adds new API client methods and updates the OpenAPI filter script for flex cluster operations
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tools/atlas/read/listClusters.ts | Updates cluster table formatting to include flex cluster data |
| src/tools/atlas/read/inspectCluster.ts | Modifies cluster inspection to use the new inspectCluster function |
| src/tools/atlas/metadata/connectCluster.ts | Updates connection string extraction with the new cluster format |
| src/common/atlas/cluster.ts | Adds helper functions for formatting both cluster types and inspection |
| src/common/atlas/apiClient.ts | Implements API methods for flex cluster operations |
| scripts/filter.ts | Adds allowed operations for flex clusters |
Co-authored-by: Copilot <[email protected]>
blva
reviewed
May 7, 2025
| return `${cluster.name} | ${clusterInstanceType} | ${clusterInstanceType == "DEDICATED" ? instanceSize : "N/A"} | ${cluster.stateName} | ${mongoDBVersion} | ${connectionString}`; | ||
| const formattedClusters = clusters?.results?.map((cluster) => formatCluster(cluster)) || []; | ||
| const formattedFlexClusters = flexClusters?.results?.map((cluster) => formatFlexCluster(cluster)) || []; | ||
| const rows = [...formattedClusters, ...formattedFlexClusters] |
There was a problem hiding this comment.
[nit] could be nice to extend tests to validate the formatting of the clsuters here, can be a follow-up
blva
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #165