Skip to content

Conversation

@mbor-dev
Copy link
Collaborator

@mbor-dev mbor-dev commented Aug 16, 2024

Add explicit snappy and zstd compressors dependencies. See https://www.mongodb.com/docs/drivers/java/sync/current/fundamentals/connection/network-compression/ for more details. The compressors versions match mongodb driver optional dependencies.

Patch: here

@mbor-dev mbor-dev requested review from blagoev and jimoleary August 16, 2024 13:48
Copy link
Collaborator

@jimoleary jimoleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the change?

Do we want to create a ticket to look at adding this to the main ycsb repo?

Can we also add some documentation on how to use this? Maybe somewhere in here?

<artifactId>core</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to leave a link to the driver docs somewhere ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited patch description to include driver link. Is there any documentation worth updating?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add the comment / link to the XML file too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments to both xmls

@mbor-dev
Copy link
Collaborator Author

mbor-dev commented Aug 19, 2024

Do we want to create a ticket to look at adding this to the main ycsb repo?

I don't think it's crucial as there is still small interest in the compressors. Also, if there will be ever decision to make one of the compressors default a new version of java driver needs to be released with required dependency to the chosen compressor. In such case it would be better to test new driver and merge that driver to the main ycsb repo.

Can we also add some documentation on how to use this? Maybe somewhere in [here]

(https://docs.devprod.prod.corp.mongodb.com/performance/workloads/YCSB_tests#parameterized-ycsb-tests)?
https://github.com/10gen/performance-tooling-docs/pull/312 - Please review, after approval I will create similar note for linkbench2

@mbor-dev mbor-dev merged commit 6f36042 into main Aug 20, 2024
@mbor-dev mbor-dev deleted the marcin.borowiec/PERF-5725 branch August 20, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants