INTPYTHON-483 Add EmbeddedModelArrayField #292
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
force-pushed
the
arrayfield+emf
branch
from
45308d2 to
1606bdb
Compare
timgraham
changed the title
timgraham
commented
May 7, 2025
Comment on lines
+251
to
+253
| for key in key_transforms: | ||
| mql = {"$getField": {"input": mql, "field": key}} | ||
| return mql |
There was a problem hiding this comment.
Is it intentional to modify the non-array embedded field?
There was a problem hiding this comment.
Yes, It was. EmbeddedModelArrayField has an embedded field and some operation could be adapted although I think this one will be reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit here is from #278. I didn't merge that in case of this work affects it.
TODO:
fixes #219