Skip to content

fix(NODE-6827): incorrect negative bigint handling #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Mar 6, 2025

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

⚠️ Fixed potential data corruption bug when useBigInt64 is enabled

After refactoring to improve deserialization performance in #649, we inadvertently introduced a bug that manifested when deserializing Long values with the useBigInt64 flag enabled. The bug would lead to negative Long values being deserialized as unsigned integers. This issue has been resolved here.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James marked this pull request as ready for review March 6, 2025 16:52
@W-A-James W-A-James changed the title fix(NODE-6764): incorrect negative bigint handling fix(NODE-6827): incorrect negative bigint handling Mar 6, 2025
@baileympearson
Copy link
Contributor

baileympearson commented Mar 6, 2025

patch: https://spruce.mongodb.com/version/67c9d46a35027a0007e51a2b/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

TS failures unrelated. Node latest tests are failing because bf5b66e is missing, and the Node18 tests are failing because we need to specify a minimum npm version. But node 16 and 20 pass.

@baileympearson baileympearson merged commit 18e6578 into v6.6.x Mar 6, 2025
1 check failed
@baileympearson baileympearson deleted the NODE-6764-6.6.x branch March 6, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants