Skip to content

Commit cb339f5

Browse files
khushalsagarmoz-wptsync-bot
authored andcommitted
Bug 1778002 [wpt PR 34693] - blink: Ensure overflow clip and visible have consistent behaviour., a=testonly
Automatic update from web-platform-tests blink: Ensure overflow clip and visible have consistent behaviour. This includes the following set of changes in preparation to add overflow:clip to all img elements in UA CSS. The aim is to have consistent behaviour between overflow:visible/clip for the following layout cases: - Use min size:auto when overflow:clip is used on a child element with the ancestor using grid layout. - Don't synthesize logical baseline for overflow:clip similar to overflow visible. See w3c/csswg-drafts#6212 for context. - When using spatial navigation, consider the topmost paint layer which has no self painting visible descendents instead of all visible descendents. This accounts for paint layers created for overflow which are for bookkeeping purposes and don't change the paint order. Bug: 1321217 Change-Id: Ibd9327da9fb830fa78e18e8cc1cb29179eaba269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3743910 Auto-Submit: Khushal Sagar <[email protected]> Commit-Queue: Khushal Sagar <[email protected]> Reviewed-by: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1020664} -- wpt-commits: 5df633bf51921f94dd0f02fa34e9a4f08d2576bf wpt-pr: 34693
1 parent 86eab25 commit cb339f5

25 files changed

+85
-85
lines changed

testing/web-platform/tests/css/css-images/object-view-box-fit-contain-canvas-ref.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
.container_view_box_subset {
1919
width: 50px;
2020
height: 100px;
21-
overflow: clip;
21+
overflow: hidden;
2222
display: inline-block;
2323
background-color: grey;
2424
}
@@ -30,7 +30,7 @@
3030
.container_view_box_subset_with_position {
3131
width: 50px;
3232
height: 100px;
33-
overflow: clip;
33+
overflow: hidden;
3434
display: inline-block;
3535
background-color: grey;
3636
}
@@ -42,7 +42,7 @@
4242
.container_view_box_subset_with_scaling {
4343
width: 100px;
4444
height: 200px;
45-
overflow: clip;
45+
overflow: hidden;
4646
display: inline-block;
4747
background-color: grey;
4848
}

testing/web-platform/tests/css/css-images/object-view-box-fit-contain-img-ref.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
.container_view_box_subset {
1919
width: 50px;
2020
height: 100px;
21-
overflow: clip;
21+
overflow: hidden;
2222
display: inline-block;
2323
background-color: grey;
2424
}
@@ -30,7 +30,7 @@
3030
.container_view_box_subset_with_position {
3131
width: 50px;
3232
height: 100px;
33-
overflow: clip;
33+
overflow: hidden;
3434
display: inline-block;
3535
background-color: grey;
3636
}
@@ -42,7 +42,7 @@
4242
.container_view_box_subset_with_scaling {
4343
width: 100px;
4444
height: 200px;
45-
overflow: clip;
45+
overflow: hidden;
4646
display: inline-block;
4747
background-color: grey;
4848
}

testing/web-platform/tests/css/css-images/object-view-box-fit-contain-svg-ref.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
.container_view_box_subset {
1919
width: 50px;
2020
height: 100px;
21-
overflow: clip;
21+
overflow: hidden;
2222
display: inline-block;
2323
background-color: grey;
2424
}
@@ -30,7 +30,7 @@
3030
.container_view_box_subset_with_position {
3131
width: 50px;
3232
height: 100px;
33-
overflow: clip;
33+
overflow: hidden;
3434
display: inline-block;
3535
background-color: grey;
3636
}
@@ -42,7 +42,7 @@
4242
.container_view_box_subset_with_scaling {
4343
width: 100px;
4444
height: 200px;
45-
overflow: clip;
45+
overflow: hidden;
4646
display: inline-block;
4747
background-color: grey;
4848
}

testing/web-platform/tests/css/css-images/object-view-box-fit-contain-video-ref.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
.container_view_box_subset {
1919
width: 50px;
2020
height: 100px;
21-
overflow: clip;
21+
overflow: hidden;
2222
display: inline-block;
2323
background-color: grey;
2424
}
@@ -30,7 +30,7 @@
3030
.container_view_box_subset_with_position {
3131
width: 50px;
3232
height: 100px;
33-
overflow: clip;
33+
overflow: hidden;
3434
display: inline-block;
3535
background-color: grey;
3636
}
@@ -42,7 +42,7 @@
4242
.container_view_box_subset_with_scaling {
4343
width: 100px;
4444
height: 200px;
45-
overflow: clip;
45+
overflow: hidden;
4646
display: inline-block;
4747
background-color: grey;
4848
}

testing/web-platform/tests/css/css-images/object-view-box-fit-cover-canvas-ref.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
.container_view_box_subset {
1919
width: 40px;
2020
height: 50px;
21-
overflow: clip;
21+
overflow: hidden;
2222
display: inline-block;
2323
}
2424
.view_box_subset {
@@ -32,7 +32,7 @@
3232
.container_view_box_subset_with_position {
3333
width: 40px;
3434
height: 50px;
35-
overflow: clip;
35+
overflow: hidden;
3636
display: inline-block;
3737
}
3838
.view_box_subset_with_position {
@@ -45,7 +45,7 @@
4545
.container_view_box_subset_with_scaling {
4646
width: 50px;
4747
height: 100px;
48-
overflow: clip;
48+
overflow: hidden;
4949
display: inline-block;
5050
clip-path: inset(1px 0px 0px 0px);
5151
}

testing/web-platform/tests/css/css-images/object-view-box-fit-cover-img-ref.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
.container_view_box_subset {
1919
width: 40px;
2020
height: 50px;
21-
overflow: clip;
21+
overflow: hidden;
2222
display: inline-block;
2323
}
2424
.view_box_subset {
@@ -32,7 +32,7 @@
3232
.container_view_box_subset_with_position {
3333
width: 40px;
3434
height: 50px;
35-
overflow: clip;
35+
overflow: hidden;
3636
display: inline-block;
3737
}
3838
.view_box_subset_with_position {
@@ -45,7 +45,7 @@
4545
.container_view_box_subset_with_scaling {
4646
width: 50px;
4747
height: 100px;
48-
overflow: clip;
48+
overflow: hidden;
4949
display: inline-block;
5050
clip-path: inset(1px 0px 0px 0px);
5151
}

testing/web-platform/tests/css/css-images/object-view-box-fit-cover-svg-ref.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
.container_view_box_subset {
1919
width: 40px;
2020
height: 50px;
21-
overflow: clip;
21+
overflow: hidden;
2222
display: inline-block;
2323
}
2424
.view_box_subset {
@@ -32,7 +32,7 @@
3232
.container_view_box_subset_with_position {
3333
width: 40px;
3434
height: 50px;
35-
overflow: clip;
35+
overflow: hidden;
3636
display: inline-block;
3737
}
3838
.view_box_subset_with_position {
@@ -45,7 +45,7 @@
4545
.container_view_box_subset_with_scaling {
4646
width: 50px;
4747
height: 100px;
48-
overflow: clip;
48+
overflow: hidden;
4949
display: inline-block;
5050
clip-path: inset(1px 0px 0px 0px);
5151
}

testing/web-platform/tests/css/css-images/object-view-box-fit-cover-video-ref.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
.container_view_box_subset {
1919
width: 40px;
2020
height: 50px;
21-
overflow: clip;
21+
overflow: hidden;
2222
display: inline-block;
2323
}
2424
.view_box_subset {
@@ -32,7 +32,7 @@
3232
.container_view_box_subset_with_position {
3333
width: 40px;
3434
height: 50px;
35-
overflow: clip;
35+
overflow: hidden;
3636
display: inline-block;
3737
}
3838
.view_box_subset_with_position {
@@ -45,7 +45,7 @@
4545
.container_view_box_subset_with_scaling {
4646
width: 50px;
4747
height: 100px;
48-
overflow: clip;
48+
overflow: hidden;
4949
display: inline-block;
5050
clip-path: inset(1px 0px 0px 0px);
5151
}

testing/web-platform/tests/css/css-images/object-view-box-fit-fill-canvas-ref.html

+8-8
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
.container_view_box_subset {
1919
width: 50px;
2020
height: 50px;
21-
overflow: clip;
21+
overflow: hidden;
2222
display: inline-block;
2323
clip-path: inset(1px 0px 0px 0px);
2424
}
@@ -30,7 +30,7 @@
3030
.container_view_box_subset_with_position {
3131
width: 50px;
3232
height: 50px;
33-
overflow: clip;
33+
overflow: hidden;
3434
background-color: grey;
3535
display: inline-block;
3636
}
@@ -43,7 +43,7 @@
4343
.container_view_box_subset_with_scaling {
4444
width: 50px;
4545
height: 100px;
46-
overflow: clip;
46+
overflow: hidden;
4747
display: inline-block;
4848
clip-path: inset(1px 0px 0px 0px);
4949
}
@@ -57,15 +57,15 @@
5757
.container_view_box_superset {
5858
width: 100px;
5959
height: 100px;
60-
overflow: clip;
60+
overflow: hidden;
6161
display: inline-block;
6262
background-color: grey;
6363
}
6464

6565
.container_view_box_superset_with_position {
6666
width: 100px;
6767
height: 100px;
68-
overflow: clip;
68+
overflow: hidden;
6969
display: inline-block;
7070
background-color: grey;
7171
}
@@ -78,7 +78,7 @@
7878
.container_view_box_superset_with_scaling {
7979
width: 50px;
8080
height: 50px;
81-
overflow: clip;
81+
overflow: hidden;
8282
display: inline-block;
8383
background-color: grey;
8484
}
@@ -91,7 +91,7 @@
9191
.container_view_box_intersection {
9292
width: 25px;
9393
height: 100px;
94-
overflow: clip;
94+
overflow: hidden;
9595
display: inline-block;
9696
background-color: grey;
9797
clip-path: inset(0px 0px 1px 0px);
@@ -106,7 +106,7 @@
106106
.container_view_box_no_intersection {
107107
width: 25px;
108108
height: 50px;
109-
overflow: clip;
109+
overflow: hidden;
110110
display: inline-block;
111111
background-color: grey;
112112
}

testing/web-platform/tests/css/css-images/object-view-box-fit-fill-img-ref.html

+8-8
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
.container_view_box_subset {
1919
width: 50px;
2020
height: 50px;
21-
overflow: clip;
21+
overflow: hidden;
2222
display: inline-block;
2323
clip-path: inset(1px 0px 0px 0px);
2424
}
@@ -30,7 +30,7 @@
3030
.container_view_box_subset_with_position {
3131
width: 50px;
3232
height: 50px;
33-
overflow: clip;
33+
overflow: hidden;
3434
background-color: grey;
3535
display: inline-block;
3636
}
@@ -43,7 +43,7 @@
4343
.container_view_box_subset_with_scaling {
4444
width: 50px;
4545
height: 100px;
46-
overflow: clip;
46+
overflow: hidden;
4747
display: inline-block;
4848
clip-path: inset(1px 0px 0px 0px);
4949
}
@@ -57,15 +57,15 @@
5757
.container_view_box_superset {
5858
width: 100px;
5959
height: 100px;
60-
overflow: clip;
60+
overflow: hidden;
6161
display: inline-block;
6262
background-color: grey;
6363
}
6464

6565
.container_view_box_superset_with_position {
6666
width: 100px;
6767
height: 100px;
68-
overflow: clip;
68+
overflow: hidden;
6969
display: inline-block;
7070
background-color: grey;
7171
}
@@ -78,7 +78,7 @@
7878
.container_view_box_superset_with_scaling {
7979
width: 50px;
8080
height: 50px;
81-
overflow: clip;
81+
overflow: hidden;
8282
display: inline-block;
8383
background-color: grey;
8484
}
@@ -91,7 +91,7 @@
9191
.container_view_box_intersection {
9292
width: 25px;
9393
height: 100px;
94-
overflow: clip;
94+
overflow: hidden;
9595
display: inline-block;
9696
background-color: grey;
9797
clip-path: inset(0px 0px 1px 0px);
@@ -106,7 +106,7 @@
106106
.container_view_box_no_intersection {
107107
width: 25px;
108108
height: 50px;
109-
overflow: clip;
109+
overflow: hidden;
110110
display: inline-block;
111111
background-color: grey;
112112
}

0 commit comments

Comments
 (0)