Allow DI for validator/rules methods #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you! Could you add a test for this? |
setContainer(app()) dependency injection via app()->call() Follow Style CI Fix unrelated style Use import Style CI Import Style-ci
Contributor
Author
|
@mpociot The method is protected and gets used in the GenerateDocumentationTest and the ApiDocGeneratorTest, those tests pass now. |
Current coverage is 89.48% (diff: 90.00%)@@ master #134 diff @@
==========================================
Files 7 7
Lines 597 618 +21
Methods 47 48 +1
Messages 0 0
Branches 0 0
==========================================
+ Hits 535 553 +18
- Misses 62 65 +3
Partials 0 0
|
Owner
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly copied from the AbstractGenerator however it allows the FormRequest to use dependency injection for the rules/validator methods
related to #133