Skip to content

Conversation

@golonix
Copy link
Contributor

@golonix golonix commented Nov 30, 2018

Resolve #415

@codecov-io
Copy link

codecov-io commented Nov 30, 2018

Codecov Report

Merging #416 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #416      +/-   ##
============================================
+ Coverage     91.54%   91.66%   +0.12%     
- Complexity      211      222      +11     
============================================
  Files            11       11              
  Lines           532      540       +8     
============================================
+ Hits            487      495       +8     
  Misses           45       45
Impacted Files Coverage Δ Complexity Δ
...c/Tools/ResponseStrategies/ResponseTagStrategy.php 100% <100%> (ø) 11 <8> (+5) ⬆️
.../Tools/ResponseStrategies/ResponseCallStrategy.php 94.69% <100%> (ø) 38 <0> (ø) ⬇️
.../Tools/ResponseStrategies/ResponseFileStrategy.php 100% <100%> (ø) 11 <8> (+5) ⬆️
src/Tools/ResponseResolver.php 100% <100%> (ø) 8 <1> (+1) ⬆️
...ols/ResponseStrategies/TransformerTagsStrategy.php 86.04% <100%> (ø) 23 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ddfb0...fb4ba04. Read the comment docs.

@shalvah
Copy link
Contributor

shalvah commented Nov 30, 2018

+1 for the backwards compatibility.

Can you upload a screenshot of what the multiple responses looks like in the generated docs?

@golonix
Copy link
Contributor Author

golonix commented Dec 1, 2018

+1 for the backwards compatibility.

Yeah, it changes nothing to current state of affairs 😉

Can you upload a screenshot of what the multiple responses looks like in the generated docs?

Docblock:

    /**
     * @response {
     *  "id": 5,
     *  "name": "Jessica Jones",
     *  "gender": "female"
     * }
     * @response 401 {
     *  "message": "Unauthenticated"
     * }
     * @response 403 {
     *  "message": "You're not authorized to perform this request"
     * }
     */

Screen shot:
screenshot 2018-12-01 at 12 28 47

@shalvah
Copy link
Contributor

shalvah commented Dec 1, 2018

Looks good. Just need a few changes.

@golonix
Copy link
Contributor Author

golonix commented Dec 3, 2018

@shalvah I briefly thought about adding an interface for strategies... what do you think?

@shalvah
Copy link
Contributor

shalvah commented Dec 3, 2018

Let's leave out the interface for now.

@shalvah shalvah merged commit 0e1418b into mpociot:master Dec 3, 2018
@golonix
Copy link
Contributor Author

golonix commented Dec 4, 2018

@shalvah one question though. Will you create a new release with this improvement or you're waiting for more stuff to come before releasing a new version?

@shalvah
Copy link
Contributor

shalvah commented Dec 4, 2018

New release coming soon...

@shalvah
Copy link
Contributor

shalvah commented Dec 5, 2018

Released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants