-
Notifications
You must be signed in to change notification settings - Fork 605
Support for multiple response tags #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multiple response tags #416
Conversation
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
============================================
+ Coverage 91.54% 91.66% +0.12%
- Complexity 211 222 +11
============================================
Files 11 11
Lines 532 540 +8
============================================
+ Hits 487 495 +8
Misses 45 45
Continue to review full report at Codecov.
|
|
+1 for the backwards compatibility. Can you upload a screenshot of what the multiple responses looks like in the generated docs? |
Yeah, it changes nothing to current state of affairs 😉
Docblock: /**
* @response {
* "id": 5,
* "name": "Jessica Jones",
* "gender": "female"
* }
* @response 401 {
* "message": "Unauthenticated"
* }
* @response 403 {
* "message": "You're not authorized to perform this request"
* }
*/ |
|
Looks good. Just need a few changes. |
|
@shalvah I briefly thought about adding an interface for strategies... what do you think? |
|
Let's leave out the interface for now. |
|
@shalvah one question though. Will you create a new release with this improvement or you're waiting for more stuff to come before releasing a new version? |
|
New release coming soon... |
|
Released. |

Resolve #415