Skip to content

Commit 047a7e9

Browse files
committed
fixup! Added OperatorSubscribeUntil and tests
1 parent 0c6b60f commit 047a7e9

File tree

1 file changed

+17
-29
lines changed

1 file changed

+17
-29
lines changed

rxandroid/src/test/java/rx/android/lifecycle/OperatorSubscribeUntilTest.java

Lines changed: 17 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -17,54 +17,42 @@
1717
import org.junit.Before;
1818
import org.junit.Test;
1919
import org.junit.runner.RunWith;
20+
import org.mockito.Mock;
21+
import org.mockito.MockitoAnnotations;
22+
import org.mockito.Spy;
2023
import org.robolectric.RobolectricTestRunner;
2124
import org.robolectric.annotation.Config;
2225
import rx.Observable;
2326
import rx.Subscriber;
24-
import rx.Subscription;
25-
import rx.functions.Action1;
26-
import rx.subjects.BehaviorSubject;
27+
import rx.observers.TestSubscriber;
2728

2829
import static org.junit.Assert.assertFalse;
29-
import static org.junit.Assert.assertTrue;
30+
import static org.mockito.Matchers.any;
31+
import static org.mockito.Mockito.never;
32+
import static org.mockito.Mockito.verify;
33+
import static org.mockito.Mockito.verifyZeroInteractions;
3034

3135
@RunWith(RobolectricTestRunner.class)
3236
@Config(manifest = Config.NONE)
3337
public class OperatorSubscribeUntilTest {
3438

35-
private Observable<Object> observable;
36-
private Subscriber<Object> subscriber;
37-
38-
// RxJava tends to swallow fail(); instead just use a subscriber to tell if onComplete was called
39-
boolean onCompleteCalled;
39+
@Spy
40+
private Subscriber<Object> subscriber = new TestSubscriber<Object>();
4041

4142
@Before
4243
public void setup() {
43-
observable = Observable.never();
44-
subscriber = new Subscriber<Object>() {
45-
@Override
46-
public void onCompleted() {
47-
onCompleteCalled = true;
48-
}
49-
50-
@Override
51-
public void onError(Throwable e) {
52-
53-
}
54-
55-
@Override
56-
public void onNext(Object o) {
57-
58-
}
59-
};
60-
onCompleteCalled = false;
44+
MockitoAnnotations.initMocks(this);
6145
}
6246

6347
@Test
6448
public void testDoesNotComplete() {
65-
observable.lift(new OperatorSubscribeUntil<Object, String>(Observable.just("Single Item")))
49+
Observable.never()
50+
.lift(new OperatorSubscribeUntil<Object, String>(Observable.just("Single Item")))
6651
.subscribe(subscriber);
67-
assertFalse(onCompleteCalled);
52+
53+
verify(subscriber, never()).onNext(any());
54+
verify(subscriber, never()).onError(any(Throwable.class));
55+
verify(subscriber, never()).onCompleted();
6856
}
6957

7058
}

0 commit comments

Comments
 (0)