Shadows on Buffergeometry with morphAttributes #9184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| geometry.morphTargets.length > 0 && material.morphTargets; | ||
| var useMorphing = ( ( geometry.morphTargets !== undefined && geometry.morphTargets.length > 0 ) || | ||
| ( geometry.morphAttributes.position !== undefined && geometry.morphAttributes.position.length > 0 ) ) | ||
| && material.morphTargets; |
Collaborator
There was a problem hiding this comment.
geometry.morphAttributes.position !== undefined
This will throw an error if geometry.morphAttributes is not defined. You can test this on the three.js examples.
An alternate pattern is if ( geometry instanceof THREE.BufferGeometry ). I am not sure which pattern is preferred. /ping @mrdoob
Contributor
Author
|
Oops. Right. Also since |
Owner
|
Looks good! |
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First contribution here, I hope I got the guidelines #8137