-
-
Notifications
You must be signed in to change notification settings - Fork 117
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: mvdan/xurls
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: mvdan/xurls
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.1.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 17 commits
- 10 files changed
- 1 contributor
Commits on Dec 26, 2018
-
I forgot that Go 1.11 and earlier don't know how to install Go modules globally. Revert to the old go get line, which does the right thing for most users not yet on modules.
Configuration menu - View commit details
-
Copy full SHA for 795eb0c - Browse repository at this point
Copy the full SHA 795eb0cView commit details
Commits on Jan 19, 2019
-
Configuration menu - View commit details
-
Copy full SHA for e73dfc8 - Browse repository at this point
Copy the full SHA e73dfc8View commit details
Commits on Feb 13, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 48f3ccc - Browse repository at this point
Copy the full SHA 48f3cccView commit details
Commits on Mar 10, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 49dda0b - Browse repository at this point
Copy the full SHA 49dda0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 729290a - Browse repository at this point
Copy the full SHA 729290aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 585be24 - Browse repository at this point
Copy the full SHA 585be24View commit details
Commits on Apr 12, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 20723a7 - Browse repository at this point
Copy the full SHA 20723a7View commit details
Commits on Jul 15, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 32cda0c - Browse repository at this point
Copy the full SHA 32cda0cView commit details -
allow Relaxed to match punycode TLDs
For example, it should match "test.xn--8y0a063a" just like it matches "test.联通". Instead of doubling the size of the regexp by adding the punycode version of every known TLD, simply match any valid punycode string which follows "xn--". It's highly unlikely that this would cause false positives. Fixes #27.
Configuration menu - View commit details
-
Copy full SHA for 776b0d8 - Browse repository at this point
Copy the full SHA 776b0d8View commit details
Commits on Jul 18, 2019
-
cmd/xurls: don't use bufio.Scanner to scan the input
It was a convenient way to obtain the input in chunks, so that the tool could print urls incrementally without having to read the entirety of the input at once. Unfortunately, we failed to notie that bufio.Scanner has a hard limit on the size of each "token". In our particular case, it meant that any sequence of many thousands of input bytes without any whitespace could make the tool error out. Instead, use bufio.Reader, which grows a buffer to fit the data being read. Go back to reading one line at a time, as it can only stop at one specific byte like '\n', and not many of them like all whitespace characters. Fixes #28.
Configuration menu - View commit details
-
Copy full SHA for 9058190 - Browse repository at this point
Copy the full SHA 9058190View commit details
Commits on Jul 26, 2019
-
don't allow | as part of a URL
This was an unintended bug added ages ago. In c64477d, we modified midChar to add \p{Po} to the character set. Unfortunately, we added |, essentially ending up with [somechars|\p{Po}]. In other words, | was now part of the set, while we only meant it as a regex "or" operator. Fix this, and add a test. Fixes #26.
Configuration menu - View commit details
-
Copy full SHA for 9b4f670 - Browse repository at this point
Copy the full SHA 9b4f670View commit details
Commits on Jul 27, 2019
-
use (?m) when looking for an end-of-line
Without it, it only matches the end of the entire input. Fixes #28, again.
Configuration menu - View commit details
-
Copy full SHA for 633779b - Browse repository at this point
Copy the full SHA 633779bView commit details
Commits on Sep 11, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 0ca2609 - Browse repository at this point
Copy the full SHA 0ca2609View commit details
Commits on Sep 22, 2019
-
Some users were repeating the regexp compile, so make that more obvious. Thanks to Kevin Burke for the idea. While at it, update the go.mod language version. Fixes #31.
Configuration menu - View commit details
-
Copy full SHA for e21d637 - Browse repository at this point
Copy the full SHA e21d637View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2427ea9 - Browse repository at this point
Copy the full SHA 2427ea9View commit details -
don't allow underscores and asterisks as end chars
This way, we match URLs within markdown emphasis like *this* or _this_ without the trailing character. It's highly unlikely that URLs would genuinely want to end in either of those characters. Asterisks are reserved, so they shouldn't be in the path to begin with. And underscores are most common in the middle of the path, and are already common to style plaintext at the start or end of URLs. Still allow them in the middle of URLs, because there's no reason not to. Fixes #29.
Configuration menu - View commit details
-
Copy full SHA for 06587e4 - Browse repository at this point
Copy the full SHA 06587e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for aca318f - Browse repository at this point
Copy the full SHA aca318fView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.0.0...v2.1.0