Skip to content

Add alg parameter to initial keys #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
loosebazooka opened this issue May 6, 2022 · 3 comments · Fixed by #248
Closed

Add alg parameter to initial keys #247

loosebazooka opened this issue May 6, 2022 · 3 comments · Fixed by #248
Labels
enhancement New feature or request

Comments

@loosebazooka
Copy link

Some clients (google-oauth-client) seem to expect the alg parameter when parsing jwks key endpoints (even though they are optional). Can we add those to the initial keys resources to expand compatibility?

@loosebazooka
Copy link
Author

For instance the jwks endpoint would return something like

 {
   "keys" : [ {
     "kty" : "RSA",
     "e" : "AQAB",
     "use" : "sig",
     "kid" : "test-default",
+    "alg" : "RSA256",
     "n" : "onZcB1ryWS1keTIcbgsLKJ1UBwL1Wbzse5P2HjkrNwbG3Jy2lefUEcTVJxN8bpLeW460Luz3ScZd3d9p8IoHjmhZ2cyO49E41aBRIlBRzWNpebK5xeC95rSKenYHpOPlLzPgybg2qxallzQUOcKCheiF0fsErlapaA9YmKwzP3DwvzYW4JqSrHhDGWPwUCcsR4dpetwKXP_9tRFso06ryr4um3qiq7giyZEyZVG3fHMplD-5e-2-RrzBiGFW_zvs-XVRGPIf9Y5YNjeQJRuS4vF82V8mNZxEZddtUY5plSz-vgX3GSvANLDH-LZJ76Zmx3a8dEZbI7VxgsBQAqcUlQ"
   } ]
 }

@ybelMekk
Copy link
Contributor

ybelMekk commented May 7, 2022

Hello @loosebazooka and thanks for opening this issue.

This can be added fairly simple.

If your keen open a PR with the suggested change and I will merge it or I can ad it.

cheers

Youssef

@ybelMekk ybelMekk added the enhancement New feature or request label May 7, 2022
@ybelMekk ybelMekk linked a pull request May 7, 2022 that will close this issue
@ybelMekk
Copy link
Contributor

ybelMekk commented May 7, 2022

@loosebazooka could you try: #248 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants