Skip to content

No longer compatible with java11? #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
loosebazooka opened this issue Oct 17, 2022 · 7 comments · Fixed by #357
Closed

No longer compatible with java11? #356

loosebazooka opened this issue Oct 17, 2022 · 7 comments · Fixed by #357
Labels
bug Something isn't working

Comments

@loosebazooka
Copy link

When moving from 0.5.1 -> 0.5.5 in gradle it looks like java11 compatibility was lost? Is this intentional? See the "org.gradle.jvm.version" attributes in modules files:

https://repo1.maven.org/maven2/no/nav/security/mock-oauth2-server/0.5.3/mock-oauth2-server-0.5.3.module
https://repo1.maven.org/maven2/no/nav/security/mock-oauth2-server/0.5.1/mock-oauth2-server-0.5.1.module

Forces me to run all my tests in Java17. I need to run them in 11 and 17.

@ybelMekk ybelMekk added bug Something isn't working breaking breaking changes, i.e. non backwards compatible api changes labels Oct 19, 2022
@ybelMekk
Copy link
Contributor

Hello @loosebazooka, intentional and unintentional at the same time? .. 😅

I configured and merged the gradle.build.kts changes so it will not run older jvms..

Could set the JVM sourceCompatibility to JavaVersion.VERSION_11 but keep target JavaVersion.VERSION_17?

@loosebazooka
Copy link
Author

I think if you're not using Java17 features, it shouldn't matter if you're keep both values at VERSION_11. But I guess this is your call as the maintainer.

Setting targetCompatibility = JavaVersion.VERSION_17 will not allow the library to be used with java11 projects. As, from what I understand, class files are generated to be only compatible with java17+.

sourceCompatibility seems to be a build time check, that metadata is not propagated to the class files. (I'm not sure why anyone would set these different -- maybe some version cross compiling business?)

@ybelMekk
Copy link
Contributor

ybelMekk commented Oct 19, 2022

I figure it's reasonable and right to keep the backward compatibility, as the tool is used for older (not as fast running, not looking back dude thinking me 🙈)

could call inn som people with a little better understanding about the problem here:
📲 -> @tommytroen , @jksolbakken

@jksolbakken
Copy link
Contributor

I don't see any issues with going back to 11, at least until the official support ends (in september 2023 iirc).

@tommytroen
Copy link
Collaborator

@ybelMekk Lets go back to 11

@ybelMekk ybelMekk linked a pull request Oct 19, 2022 that will close this issue
@ybelMekk ybelMekk removed the breaking breaking changes, i.e. non backwards compatible api changes label Oct 20, 2022
@loosebazooka
Copy link
Author

thanks for the quick release!

@ybelMekk
Copy link
Contributor

thanks for the quick release!

This is on me. Thanks for reporting 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants