fix: improve link fallback when OSC 8 is not supported #7294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 80652f6
|
The `terminal-link` package uses [OSC 8](https://github.com/Alhadis/OSC8-Adoption/) link formatting when running in a terminal that supports it. When it isn't supported, by default it falls back to rendering the text followed by the link in parens. This is fine, but when we pass the full URL as the text, it's unnecessarily noisy, e.g.: https://example.com/foo/bar (https://example.com/foo/bar) Passing `fallback: false` toggles the fallback behaviour to just render the text as-is. This wasn't clear previously from the docs: sindresorhus/terminal-link#26.
serhalp
force-pushed
the
fix/improve-fallback-terminal-link-formatting
branch
from
29c2337 to
95a6ac4
Compare
JakeChampion
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
terminal-linkpackage uses OSC 8 link formatting when running in a terminal that supports it. When it isn't supported, by default it falls back to rendering the text followed by the link in parens. This is fine, but when we pass the full URL as the text, it's unnecessarily noisy, e.g.:Passing
fallback: falsetoggles the fallback behaviour to just render the text as-is, e.g.:This wasn't clear previously from the docs: sindresorhus/terminal-link#26.