Skip to content

Mailgun Provider needs option for EU server (domain is different) #11923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
notflip opened this issue Sep 29, 2024 · 1 comment
Closed

Mailgun Provider needs option for EU server (domain is different) #11923

notflip opened this issue Sep 29, 2024 · 1 comment
Labels
bug Something isn't working invalid reproduction The issue did not have a detectable valid reproduction URL triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime.

Comments

@notflip
Copy link

notflip commented Sep 29, 2024

Environment

System:
OS: macOS 14.6.1
CPU: (8) x64 Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz
Memory: 842.31 MB / 16.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
Yarn: 1.22.22 - /usr/local/bin/yarn
npm: 10.2.3 - ~/.nvm/versions/node/v20.10.0/bin/npm
pnpm: 9.1.1 - /usr/local/bin/pnpm
Browsers:
Brave Browser: 129.1.70.119
Safari: 17.6
npmPackages:
@auth/supabase-adapter: ^1.4.2 => 1.4.2
next: 14.2.6 => 14.2.6
next-auth: 5.0.0-beta.22 => 5.0.0-beta.22
react: ^18 => 18.3.1

Reproduction URL

can't

Describe the issue

In the mailgun.ts file, the default Mailgun link is used, but there's 2 (one for europe as well).
We should make sure we can set it as a config

If we add a variable that can add .eu in front of .mailgun, we're good to go.

See line: const res = await fetch(https://api.eu.mailgun.net/v3/${domain}/messages`,`

export default function MailGun(config) {
    return {
        id: "mailgun",
        type: "email",
        name: "Mailgun",
        from: "Auth.js <[email protected]>",
        maxAge: 24 * 60 * 60,
        async sendVerificationRequest(params) {
            const { identifier: to, provider, url, theme } = params;
            const { host } = new URL(url);
            const domain = provider.from?.split("@").at(1);
            if (!domain)
                throw new Error("malformed Mailgun domain");
            const form = new FormData();
            form.append("from", `${provider.name} <${provider.from}>`);
            form.append("to", to);
            form.append("subject", `Sign in to ${host}`);
            form.append("html", html({ host, url, theme }));
            form.append("text", text({ host, url }));
            const res = await fetch(`https://api.eu.mailgun.net/v3/${domain}/messages`, {
                method: "POST",
                headers: {
                    Authorization: `Basic ${btoa(`api:${provider.apiKey}`)}`,
                },
                body: form,
            });
            if (!res.ok)
                throw new Error("Mailgun error: " + (await res.text()));
        },
        options: config,
    };
}

### How to reproduce

(Mailgun for EU specific, so you can't)

### Expected behavior

Have a config variable to choose the EU server, 
@notflip notflip added bug Something isn't working triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. labels Sep 29, 2024
Copy link

We could not detect a valid reproduction link. Make sure to follow the bug report template carefully.

Why was this issue closed?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We need a link to a public GitHub repository. Example: (NextAuth.js example repository).

The bug template that you filled out has a section called "Reproduction URL", which is where you should provide the link to the reproduction.

  • If you did not provide a link or the link you provided is not hosted on github.com outside of the next-auth organization, we will close the issue.
  • If you provide a link to a private repository, we will close the issue.
  • If you provide a link to a repository but not in the correct section, we will close the issue.

What should I do?

Depending on the reason the issue was closed, you can do the following:

  • If you did not provide a link hosted on github.com outside of the next-auth organization, please open a new issue with a link to such a reproduction.
  • If you provided a link to a private repository, please open a new issue with a link to a public repository.
  • If you provided a link to a repository but not in the correct section, please open a new issue with a link to a reproduction in the correct section.

In general, assume that we should not go through a lengthy onboarding process at your company code only to be able to verify an issue.

My repository is private and cannot make it public

In most cases, a private repo will not be a sufficient minimal reproduction, as this codebase might contain a lot of unrelated parts that would make our investigation take longer. Please do not make it public. Instead, create a new repository using the templates above, adding the relevant code to reproduce the issue. Common things to look out for:

  • Remove any code that is not related to the issue. (pages, API Routes, components, etc.)
  • Remove any dependencies that are not related to the issue.
  • Remove any third-party service that would require us to sign up for an account to reproduce the issue.
  • Remove any environment variables that are not related to the issue.
  • Remove private packages that we do not have access to.
  • If the issue is not related to a monorepo specifically, try to reproduce the issue without a complex monorepo setup

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps by opening a new issue.

I think my reproduction is good enough, why aren't you looking into it quickly?

We look into every issue and monitor open issues for new comments.

However, sometimes we might miss a few due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources

@github-actions github-actions bot added the invalid reproduction The issue did not have a detectable valid reproduction URL label Sep 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working invalid reproduction The issue did not have a detectable valid reproduction URL triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime.
Projects
None yet
Development

No branches or pull requests

1 participant