make special secrets array a pointer

pdabelf5 · pdabelf5 · commit 3d30f6ae5ea4 · 2024-11-28T11:46:32.000Z
diff --git a/internal/k8s/controller.go b/internal/k8s/controller.go
@@ -1781,7 +1781,7 @@ func (lbc *LoadBalancerController) handleSpecialSecretUpdate(secret *api_v1.Secr
 	var specialTLSSecretsToUpdate []string
 	secretNsName := generateSecretNSName(secret)
 
-	if ok := lbc.specialSecretValidation(secretNsName, secret, specialTLSSecretsToUpdate); !ok {
+	if ok := lbc.specialSecretValidation(secretNsName, secret, &specialTLSSecretsToUpdate); !ok {
 		// if not ok bail early
 		return
 	}
@@ -1803,12 +1803,12 @@ func (lbc *LoadBalancerController) writeSpecialSecrets(secret *api_v1.Secret, sp
 	lbc.configurator.AddOrUpdateSpecialTLSSecrets(secret, specialTLSSecretsToUpdate)
 }
 
-func (lbc *LoadBalancerController) specialSecretValidation(secretNsName string, secret *api_v1.Secret, specialTLSSecretsToUpdate []string) bool {
+func (lbc *LoadBalancerController) specialSecretValidation(secretNsName string, secret *api_v1.Secret, specialTLSSecretsToUpdate *[]string) bool {
 	if secretNsName == lbc.specialSecrets.defaultServerSecret {
-		lbc.validationTLSSpecialSecret(secret, configs.DefaultServerSecretFileName, &specialTLSSecretsToUpdate)
+		lbc.validationTLSSpecialSecret(secret, configs.DefaultServerSecretFileName, specialTLSSecretsToUpdate)
 	}
 	if secretNsName == lbc.specialSecrets.wildcardTLSSecret {
-		lbc.validationTLSSpecialSecret(secret, configs.WildcardSecretFileName, &specialTLSSecretsToUpdate)
+		lbc.validationTLSSpecialSecret(secret, configs.WildcardSecretFileName, specialTLSSecretsToUpdate)
 	}
 	return true
 }

Original file line number	Diff line number	Diff line change
`@@ -1781,7 +1781,7 @@ func (lbc LoadBalancerController) handleSpecialSecretUpdate(secret api_v1.Secr`
`1781`	`1781`	`var specialTLSSecretsToUpdate []string`
`1782`	`1782`	`secretNsName := generateSecretNSName(secret)`
`1783`	`1783`
`1784`		`- if ok := lbc.specialSecretValidation(secretNsName, secret, specialTLSSecretsToUpdate); !ok {`
	`1784`	`+ if ok := lbc.specialSecretValidation(secretNsName, secret, &specialTLSSecretsToUpdate); !ok {`
`1785`	`1785`	`// if not ok bail early`
`1786`	`1786`	`return`
`1787`	`1787`	`}`
`@@ -1803,12 +1803,12 @@ func (lbc LoadBalancerController) writeSpecialSecrets(secret api_v1.Secret, sp`
`1803`	`1803`	`lbc.configurator.AddOrUpdateSpecialTLSSecrets(secret, specialTLSSecretsToUpdate)`
`1804`	`1804`	`}`
`1805`	`1805`
`1806`		`-func (lbc LoadBalancerController) specialSecretValidation(secretNsName string, secret api_v1.Secret, specialTLSSecretsToUpdate []string) bool {`
	`1806`	`+func (lbc LoadBalancerController) specialSecretValidation(secretNsName string, secret api_v1.Secret, specialTLSSecretsToUpdate *[]string) bool {`
`1807`	`1807`	`if secretNsName == lbc.specialSecrets.defaultServerSecret {`
`1808`		`- lbc.validationTLSSpecialSecret(secret, configs.DefaultServerSecretFileName, &specialTLSSecretsToUpdate)`
	`1808`	`+ lbc.validationTLSSpecialSecret(secret, configs.DefaultServerSecretFileName, specialTLSSecretsToUpdate)`
`1809`	`1809`	`}`
`1810`	`1810`	`if secretNsName == lbc.specialSecrets.wildcardTLSSecret {`
`1811`		`- lbc.validationTLSSpecialSecret(secret, configs.WildcardSecretFileName, &specialTLSSecretsToUpdate)`
	`1811`	`+ lbc.validationTLSSpecialSecret(secret, configs.WildcardSecretFileName, specialTLSSecretsToUpdate)`
`1812`	`1812`	`}`
`1813`	`1813`	`return true`
`1814`	`1814`	`}`