Skip to content

RouteNavigationPayload is not serialization-compliant #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
s-ve opened this issue May 21, 2017 · 2 comments
Closed

RouteNavigationPayload is not serialization-compliant #27

s-ve opened this issue May 21, 2017 · 2 comments

Comments

@s-ve
Copy link

s-ve commented May 21, 2017

Currently, RouteNavigationPayload stores a reference to a RouterStateSnapshot instance.

RouterStateSnapshot is likely to contain circular references (e.g. child routes have pointers to their parent) and thus it prevents navigation actions to be properly encoded as a JSON string.

As mentioned in this thread, unserializable actions are not advised as they can lead to compatibility issues with some redux libraries/tools.

Do you plan to address this issue in the future by converting navigation actions into "serialization-compliant" objects ?
@Matmo10
Copy link

Matmo10 commented May 21, 2017

See #12

@s-ve
Copy link
Author

s-ve commented May 22, 2017

Closing this since it's already being discussed in #12

@s-ve s-ve closed this as completed May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Matmo10 @s-ve