Skip to content
This repository was archived by the owner on Sep 2, 2023. It is now read-only.

Feature: Spec compliance #132

Closed
GeoffreyBooth opened this issue Jun 18, 2018 · 5 comments
Closed

Feature: Spec compliance #132

GeoffreyBooth opened this issue Jun 18, 2018 · 5 comments
Labels

Comments

@GeoffreyBooth
Copy link
Member

The modules implementation that ships as part of Node core is fully compliant with all relevant specifications.

Use case 59.

(For many people this kind of goes without saying, but I think it’s worth enumerating as a feature to be prioritized along with all the other features and goals of the implementation.)

@bmeck
Copy link
Member

bmeck commented Jun 18, 2018

I'd note that this is a meta-feature, it affects basically everything and isn't exactly a feature in itself?

@GeoffreyBooth
Copy link
Member Author

Yeah, feature, meta-feature, however you want to describe it. I think it is worth mentioning, as I feel like there shouldn’t be “assumed” features or requirements that we’re not specifying.

It’s also probably not a bad idea to give this a thread of its own, as there’s definitely some debate as to the spec itself on certain points, such as whether it covers CommonJS or not, etc. @bmeck do you have some links to the relevant spec or specs? Those would be good to include in the top post.

@devsnek
Copy link
Member

devsnek commented Jun 18, 2018

I feel like there shouldn’t be “assumed” features or requirements that we’re not specifying.

as long as we're still making es modules we are inherently following a specification. if the final product doesn't visibly match the spec it isn't es modules, its something else.

@bmeck
Copy link
Member

bmeck commented Jun 18, 2018

@GeoffreyBooth
I could just state the general phrasing that I'm starting to lean on:

Spec text is not implementation text, see conformance criteria , an example of expected optimization in contradiction with spec text implementation , and algorithm conventions.

from: https://docs.google.com/presentation/d/14Jn4ry0rlONMd2Yc1ZdFl-aU42XKVEgOc9x2Hy9C9ZI/edit#slide=id.g3c73ede8b6_0_155

All things integrating with the spec need to abide by the same conformance and algorithm criteria, regardless of if it is documented in the specification or not that includes loading CommonJS/JSON/HTML due to the algorithm conventions callout about semantics.

@ljharb
Copy link
Member

ljharb commented Jun 18, 2018

It's node dot JS, i think it's definitely assumed that it complies with the JS spec.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants