fix: accurately define ncu-ci report condition #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problems are ignored if they occurred in less than two PRs. Thus, they are reported if they failed in two or more PRs.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #697 +/- ##
=======================================
Coverage 83.38% 83.38%
=======================================
Files 37 37
Lines 4158 4158
=======================================
Hits 3467 3467
Misses 691 691 ☔ View full report in Codecov by Sentry. |
MoLow
reviewed
May 3, 2023
| @@ -72,7 +72,7 @@ export class FailureAggregator { | |||
| let output = 'Failures in '; | |||
| output += `[${jobName}/${first.jobid}](${first.link}) to `; | |||
| output += `[${jobName}/${last.jobid}](${last.link}) `; | |||
| output += 'that failed more than 2 PRs\n'; | |||
| output += 'that failed 2 or more PRs\n'; | |||
There was a problem hiding this comment.
Suggested change
| output += 'that failed 2 or more PRs\n'; | |
| output += 'that failed multiple PRs\n'; |
MoLow
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems are ignored if they occurred in less than two PRs. Thus, they are reported if they failed in two or more PRs.
node-core-utils/lib/ci/failure_aggregator.js
Lines 88 to 89 in ecb1b7d