Skip to content

fix(ncu-ci): fetch commits instead of PR metadata #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 31, 2025

I was testing #911, I noticed I would get No commits found errors, and indeed it looks like I forgot to change the API call now that we're no longer relying on the PR metadata.

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.70%. Comparing base (5ec915b) to head (9eabd4c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/pr_checker.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #915   +/-   ##
=======================================
  Coverage   79.70%   79.70%           
=======================================
  Files          39       39           
  Lines        4642     4642           
=======================================
  Hits         3700     3700           
  Misses        942      942           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95
Copy link
Contributor Author

aduh95 commented Mar 31, 2025

/cc @nodejs/node-core-utils

@aduh95 aduh95 merged commit af52aa3 into nodejs:main Apr 1, 2025
12 of 13 checks passed
@aduh95 aduh95 deleted the do-not-rely-timelineItems branch April 1, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants