feat(git-node): auto-unshallow shallow clones #918
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NCU expects the local clone to not be shallow, and throws arguably confusing errors when running
git node land
on a shallow clone. We might pass the correct flag if we detect unshallowness.For a concrete example, that would allow us to use shallow clone in the CQ, and lazy-unshallow only if there are PRs ready to land (currently, if there's a PRs that was open for more than 2 days, and CI is still running, it will cause CQ to fully clone the repo every 10 minutes for nothing).