Skip to content

feat(git-node): auto-unshallow shallow clones #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 5, 2025

NCU expects the local clone to not be shallow, and throws arguably confusing errors when running git node land on a shallow clone. We might pass the correct flag if we detect unshallowness.

For a concrete example, that would allow us to use shallow clone in the CQ, and lazy-unshallow only if there are PRs ready to land (currently, if there's a PRs that was open for more than 2 days, and CI is still running, it will cause CQ to fully clone the repo every 10 minutes for nothing).

NCU expects the local clone to not be shallow, and throws arguably
confusing errors when running `git node land` on a shallow clone. We
might pass the correct flag if we detect unshallowness.
Copy link

codecov bot commented Apr 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.70%. Comparing base (ef135f5) to head (628d7c4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #918   +/-   ##
=======================================
  Coverage   79.70%   79.70%           
=======================================
  Files          39       39           
  Lines        4642     4642           
=======================================
  Hits         3700     3700           
  Misses        942      942           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 merged commit 7bf2350 into nodejs:main Apr 6, 2025
13 checks passed
@aduh95 aduh95 deleted the auto-unshallow branch April 6, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants