-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add completion for set-script
#2925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
reviewed
Mar 23, 2021
set-script
ruyadorno
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome 🙌 thanks!
`npm install` should not be affected by the `auditLevel` config, as the results of audit do not change its exit status. PR-URL: #2929 Credit: @wraithgar Close: #2929 Reviewed-by: @ljharb, @ruyadorno
This is a valid level but wasn't configured to be allowed. Also added this param to the usage output for `npm audit` PR-URL: #2923 Credit: @wraithgar Close: #2923 Reviewed-by: @ruyadorno
PR-URL: #2945 Credit: @nlf Close: #2945 Reviewed-by: @wraithgar
The logger was no longer in flatOptions, we pass it in explicitly now PR-URL: #2944 Credit: @wraithgar Close: #2944 Reviewed-by: @nlf
This was not being added to flatOptions, and things like `npm-registry-fetch` are looking for it. PR-URL: #2946 Credit: @wraithgar Close: #2946 Reviewed-by: @nlf
PR-URL: #2925 Credit: @Yash-Singh1 Close: #2925 Reviewed-by: @ruyadorno
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Release 7.x
work is associated with a specific npm 7 release
semver:patch
semver patch level for changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements tab completion for
set-script
. Most of the code fromrun-script
.