Skip to content

fix(FormGroup): hydration mismatch on inputId #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 14, 2023
Merged

fix(FormGroup): hydration mismatch on inputId #942

merged 5 commits into from
Nov 14, 2023

Conversation

@romhml
Copy link
Member

@romhml romhml commented Nov 10, 2023 •
edited by benjamincanac
Loading

πŸ”— Linked issue

Fixes #926

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@vercel
Copy link
Contributor

vercel bot commented Nov 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
ui βœ… Ready (Inspect) Visit Preview Nov 14, 2023 11:50am

@romhml romhml mentioned this pull request Nov 10, 2023
Closed
@romhml
Copy link
Member Author

romhml commented Nov 14, 2023

@benjamincanac the PR is ready. I fixed the issue by forcing all input unique identifiers to be generated onMounted to avoid hydration mismatch and collisions (between ids generated server side & client side).

This is not ideal but it should work while we wait for nuxt/nuxt#23368 to implement something cleaner.

@romhml romhml marked this pull request as ready for review November 14, 2023 11:42
@benjamincanac
Copy link
Member

benjamincanac commented Nov 14, 2023

Thanks a lot @romhml!!! 😊

@benjamincanac benjamincanac changed the title fix(FormGroup): fix hydration mismatch on inputId fix(FormGroup): hydration mismatch on inputId Nov 14, 2023
@benjamincanac benjamincanac merged commit a3046aa into dev Nov 14, 2023
@benjamincanac benjamincanac deleted the fix-form-group-uid branch November 14, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FormGroup]: labels not getting same uid as inputs

3 participants

@romhml @benjamincanac