fix(Link): check disabled prop before navigating
#1321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
package-lock.json
Outdated
Member
There was a problem hiding this comment.
Would you mind removing the lock?
Contributor
Author
There was a problem hiding this comment.
Not a problem. Would do just that
benjamincanac
changed the title
disabled prop before navigating
benjamincanac
approved these changes
Feb 6, 2024
Member
|
Thanks! π |
solamichealolawale
deleted the
fix/ubutton-disabled-to-attribute-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolves #1320
β Type of change
π Description
This pull request addresses the issue where the disabled attribute of the
UButton&ULinkcomponent fails to function properly when used alongside the:toattribute. Currently, even when the button is disabled, clicking on it still triggers the redirection, disregarding the disabled stateπ Checklist